Fix temporary path crash in TestAuthDatabase (#7753)

SmallJoker · web-flow · commit b9343a7da4b0 · 2018-09-28T20:12:11.000+02:00
The constructor of TestAuthDatabase was called immediately, at a time when the settings weren't initialized properly yet.
diff --git a/src/unittest/test_authdatabase.cpp b/src/unittest/test_authdatabase.cpp
@@ -90,12 +90,7 @@ class SQLite3Provider : public AuthDatabaseProvider
 class TestAuthDatabase : public TestBase
 {
 public:
-	TestAuthDatabase()
-	{
-		TestManager::registerTestModule(this);
-		// fixed directory, for persistence
-		test_dir = getTestTempDirectory();
-	}
+	TestAuthDatabase() { TestManager::registerTestModule(this); }
 	const char *getName() { return "TestAuthDatabase"; }
 
 	void runTests(IGameDef *gamedef);
@@ -112,14 +107,16 @@ class TestAuthDatabase : public TestBase
 	void testDelete();
 
 private:
-	std::string test_dir;
 	AuthDatabaseProvider *auth_provider;
 };
 
 static TestAuthDatabase g_test_instance;
 
 void TestAuthDatabase::runTests(IGameDef *gamedef)
 {
+	// fixed directory, for persistence
+	thread_local const std::string test_dir = getTestTempDirectory();
+
 	// Each set of tests is run twice for each database type:
 	// one where we reuse the same AuthDatabase object (to test local caching),
 	// and one where we create a new AuthDatabase object for each call
