Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teeworlds: 0.6.4 -> 0.6.5 #48528

Merged
merged 1 commit into from Oct 16, 2018
Merged

teeworlds: 0.6.4 -> 0.6.5 #48528

merged 1 commit into from Oct 16, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 16, 2018

This release adds support for building with cmake!
So switch to that eagerly instead of fighting with bam.

(if nothing else cmake is the devil we know...)

Also:

  • fixup 'DATA_DIR' so programs can find resources
    (without need for wrappers)
  • install readme+license as previously done ("docs")
  • added wavpack since we have it packaged, shrug :)
  • don't install tools since not built or installed by default
    • esp since doesn't appear to have non-adhoc method for installation
    • other distros don't seem to include
  • dropped version portion of name used in 'share'
    • upstream doesn't use it when installing
    • quick check in my ~/.nix-profile suggests it's not the norm
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
teeworlds: 0.6.4 -> 0.6.5
18258ba 
This release adds support for building with cmake!
So switch to that eagerly instead of fighting with bam.

(if nothing else cmake is the devil we know...)

Also:

* fixup 'DATA_DIR' so programs can find resources
  (without need for wrappers)
* install readme+license as previously done ("docs")
* don't install tools since not built or installed by default
  * esp since doesn't appear to have non-adhoc method for installation
  * other distros don't seem to include
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: teeworlds

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: teeworlds

Partial log (click to expand)

'CMakeCache.txt' -> '/nix/store/zlxz2xcp43zx6bj1dl3991br3z4cyysv-teeworlds-0.6.5/share/doc/teeworlds/CMakeCache.txt'
'install_manifest.txt' -> '/nix/store/zlxz2xcp43zx6bj1dl3991br3z4cyysv-teeworlds-0.6.5/share/doc/teeworlds/install_manifest.txt'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zlxz2xcp43zx6bj1dl3991br3z4cyysv-teeworlds-0.6.5
shrinking /nix/store/zlxz2xcp43zx6bj1dl3991br3z4cyysv-teeworlds-0.6.5/bin/teeworlds_srv
shrinking /nix/store/zlxz2xcp43zx6bj1dl3991br3z4cyysv-teeworlds-0.6.5/bin/teeworlds
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zlxz2xcp43zx6bj1dl3991br3z4cyysv-teeworlds-0.6.5/bin
patching script interpreter paths in /nix/store/zlxz2xcp43zx6bj1dl3991br3z4cyysv-teeworlds-0.6.5
checking for references to /build in /nix/store/zlxz2xcp43zx6bj1dl3991br3z4cyysv-teeworlds-0.6.5...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: teeworlds

Partial log (click to expand)

'CMakeCache.txt' -> '/nix/store/jcax7y8iy6hv3y6dlc80y46ygh8zih3z-teeworlds-0.6.5/share/doc/teeworlds/CMakeCache.txt'
'install_manifest.txt' -> '/nix/store/jcax7y8iy6hv3y6dlc80y46ygh8zih3z-teeworlds-0.6.5/share/doc/teeworlds/install_manifest.txt'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jcax7y8iy6hv3y6dlc80y46ygh8zih3z-teeworlds-0.6.5
shrinking /nix/store/jcax7y8iy6hv3y6dlc80y46ygh8zih3z-teeworlds-0.6.5/bin/teeworlds
shrinking /nix/store/jcax7y8iy6hv3y6dlc80y46ygh8zih3z-teeworlds-0.6.5/bin/teeworlds_srv
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jcax7y8iy6hv3y6dlc80y46ygh8zih3z-teeworlds-0.6.5/bin
patching script interpreter paths in /nix/store/jcax7y8iy6hv3y6dlc80y46ygh8zih3z-teeworlds-0.6.5
checking for references to /build in /nix/store/jcax7y8iy6hv3y6dlc80y46ygh8zih3z-teeworlds-0.6.5...

@Mic92 Mic92 merged commit 5c06558 into NixOS:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @Mic92