Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcpretty init #48494

Merged
merged 2 commits into from Nov 28, 2018
Merged

xcpretty init #48494

merged 2 commits into from Nov 28, 2018

Conversation

nicknovitski
Copy link
Contributor

@nicknovitski nicknovitski commented Oct 16, 2018 •
edited

Xcpretty is a command-line tool which fastlane invokes, but sometimes I use it directly.
I added the updateScript attribute to fastlane because it updates very frequently.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nicknovitski
Copy link
Contributor Author

Are updateScript attributes not the current best practice for updateable packages? If not, I can remove them.

@nicknovitski nicknovitski changed the title xcpretty init, and connect updateScript to fastlane xcpretty init Nov 21, 2018
@nicknovitski
Copy link
Contributor Author

I've changed this pr to only add the xcpretty command line tool.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2018

It should live under pkgs/development/tools instead of pkgs/tools/admin

Change the call from all-packages.nix accordingly.
And its position in the file: there is a ### DEVELOPMENT / TOOLS section

@nicknovitski
Copy link
Contributor Author

Sure. I was just following the positioning of fastlane, since I think of them as related tools.

@nicknovitski
Copy link
Contributor Author

Moved to pkgs/development/tools/xcpretty and the DEVELOPMENT / TOOLS section.

alyssais
alyssais requested changes Nov 27, 2018
View reviewed changes
pkgs/development/tools/xcpretty/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/xcpretty/update Outdated Show resolved Hide resolved
pkgs/development/tools/xcpretty/update Outdated Show resolved Hide resolved
pkgs/development/tools/xcpretty/update Outdated Show resolved Hide resolved
pkgs/development/tools/xcpretty/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/xcpretty/default.nix Show resolved Hide resolved
@nicknovitski
Copy link
Contributor Author

Updated to use bundlerApp (which I also changed a bit), changed the updateScript to recommendations and made it an inline string following a pattern in nix-pin, nix-update-source, and gup, which locks down the versions of bundler and bundix it uses.

@nicknovitski
Copy link
Contributor Author

nicknovitski commented Nov 28, 2018 •
edited

Reverted the addition of a default value for bundlerApp's exes argument.

@zimbatm zimbatm merged commit f2c07cd into NixOS:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais requested changes

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nicknovitski @c0bw3b @zimbatm @alyssais @GrahamcOfBorg