Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 18.09: haskellPackages.cryptonite: fix for aarch64 and re-enable tests #48486

Merged
merged 2 commits into from Oct 15, 2018
Merged

Backport 18.09: haskellPackages.cryptonite: fix for aarch64 and re-enable tests #48486

merged 2 commits into from Oct 15, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Oct 15, 2018

Motivation for this change

#48485

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dhess @srhb
haskellPackages.cryptonite: re-enable tests.
fbb068d 
This has been fixed since cryptonite-0.7:

haskell-crypto/cryptonite#28

cryptonite is also no longer listed in expected-test-failures in
Stackage.

(cherry picked from commit c8a59e8)
Backport of NixOS#48485
@dhess @srhb
haskellPackages.cryptonite: fix for aarch64.
67a7354 
This is a cherry-pick from upstream (see
haskell-crypto/cryptonite#234); there has
been no upstream release since the fix was committed.

(cherry picked from commit 321626d)
Backport of NixOS#48485
@srhb
Copy link
Contributor Author

srhb commented Oct 15, 2018

@GrahamcOfBorg build haskellPackages.cryptonite

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.cryptonite

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.cryptonite

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ww4frrycgxim2y748xy65vbpfiny55x9-cryptonite-0.25/lib
patching script interpreter paths in /nix/store/ww4frrycgxim2y748xy65vbpfiny55x9-cryptonite-0.25
checking for references to /build in /nix/store/ww4frrycgxim2y748xy65vbpfiny55x9-cryptonite-0.25...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/wf4al2vz7h9sgqk4pxiw2hgx0dypdwgg-cryptonite-0.25-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/wf4al2vz7h9sgqk4pxiw2hgx0dypdwgg-cryptonite-0.25-doc
checking for references to /build in /nix/store/wf4al2vz7h9sgqk4pxiw2hgx0dypdwgg-cryptonite-0.25-doc...
/nix/store/ww4frrycgxim2y748xy65vbpfiny55x9-cryptonite-0.25

@dhess
Copy link
Contributor

dhess commented Oct 15, 2018

I think that re-enabling tests on cryptonite on 18.09 is a fine idea, but note that the other effect of this patch -- to fix cryptonite on aarch64 -- will not have any effect on 18.09 until 4babe7f and a1600d0, which made GHC work on aarch64, are also backported.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.cryptonite

Partial log (click to expand)

Preprocessing test suite 'test-cryptonite' for cryptonite-0.25..
installing
Installing library in /nix/store/n48pgxfava049s88d258kcmnd1cpvwzk-cryptonite-0.25/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/cryptonite-0.25-Djld4dYfcfX6QsXRsmIscF
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/n48pgxfava049s88d258kcmnd1cpvwzk-cryptonite-0.25/lib
patching script interpreter paths in /nix/store/n48pgxfava049s88d258kcmnd1cpvwzk-cryptonite-0.25
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/46lb8wvpmxa4ayqqa1k8c4jni5bi6x1l-cryptonite-0.25-doc
/nix/store/n48pgxfava049s88d258kcmnd1cpvwzk-cryptonite-0.25

@srhb srhb merged commit 24bab87 into NixOS:release-18.09 Oct 15, 2018
@srhb srhb deleted the backport-48485 branch October 15, 2018 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @GrahamcOfBorg @dhess