haskellPackages.cryptonite: fix for aarch64 and re-enable tests #48485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been fixed since cryptonite-0.7: haskell-crypto/cryptonite#28 cryptonite is also no longer listed in expected-test-failures in Stackage.
This is a cherry-pick from upstream (see haskell-crypto/cryptonite#234); there has been no upstream release since the fix was committed.
|
@GrahamcOfBorg build haskellPackages.cryptonite |
|
Success on aarch64-linux (full log) Attempted: haskellPackages.cryptonite Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: haskellPackages.cryptonite Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: haskellPackages.cryptonite Partial log (click to expand)
|
|
Thanks! |
srhb
pushed a commit
to srhb/nixpkgs
that referenced
this pull request
Oct 15, 2018
This has been fixed since cryptonite-0.7: haskell-crypto/cryptonite#28 cryptonite is also no longer listed in expected-test-failures in Stackage. (cherry picked from commit c8a59e8) Backport of NixOS#48485
srhb
pushed a commit
to srhb/nixpkgs
that referenced
this pull request
Oct 15, 2018
This is a cherry-pick from upstream (see haskell-crypto/cryptonite#234); there has been no upstream release since the fix was committed. (cherry picked from commit 321626d) Backport of NixOS#48485
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
cryptonitehas beendontCheckfor nearly 3 years:358db2a
but the test failures that led to that nixpkgs commit were fixed upstream around the same time:
haskell-crypto/cryptonite#28
The first patch in this series re-enables tests for
cryptonite.Meanwhile,
cryptonite-0.25has a bug onaarch64that was not caught because the tests are disabled. It only manifested in test failures on that arch intls. The fix for this issue has been committed upstream, but no release has been made since, so the second patch in this series cherry-picks the commit fromcryptoniteupstream foraarch64. The fix is guarded by a check for that architecture, so it does not impact other architectures.As an aside, a package like
cryptoniteseems like a very dangerous one to leavedontCheckfor so long. Probably there should be some way to revisit, from time to time, packages whose tests have been disabled. One idea would be to run an occasional Hydra build wheredontCheckis a no-op./cc @srhb
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)