Add --graphml option to the nix-store --query command #2479
Conversation
src/nix-store/graphml.cc
Outdated
|
|
||
| static string makeEdge(const string & src, const string & dst) | ||
| { | ||
| format f = format(" <edge source=\"%1%\" target=\"%2%\"/>\n") |
There was a problem hiding this comment.
Maybe return fmt(..., xmlQuote(src), xmlQuote(dst));? Saves the need for calling f.str().
src/nix-store/graphml.cc
Outdated
| workList.erase(path); | ||
|
|
||
| if (doneSet.find(path) != doneSet.end()) continue; | ||
| doneSet.insert(path); |
There was a problem hiding this comment.
Maybe check the return value of insert instead (.second)? Shorter and saves searching again for the insert.
|
|
||
| for (auto & p : store->queryPathInfo(path)->references) { | ||
| if (p != path) { | ||
| workList.insert(p); |
There was a problem hiding this comment.
Using a std::set for the worklist might not be the best, and seems like would have an unusual ordering, niether BFS nor DFS but ... alphabetically (of the current worklist)? If so, I imagine it doesn't matter to tools reading it but might annoy or confuse someone inspecting it by hand.
There was a problem hiding this comment.
I'm not sure it's really useful to make the code more complex to have a more xml human readable file (the goal of this PR is to generate a file that can be easily parsed by several tools).
I wonder why the set of paths is ordered while there is an unordered_set container in the std lib (I have a patch that uses an unordered_set in this file that I could include if it is pertinent).
|
Yeah I think it's fine to replace |
|
I'll add docs and remove |
nlewo
changed the title
This prints the references graph of the store paths in the graphML format [1]. The graphML format is supported by several graph tools such as the Python Networkx library or the Apache Thinkerpop project. [1] http://graphml.graphdrawing.org
The `--graphml` option can be used instead.
nlewo
changed the title
|
I've added docs and removed @dtzWill FYI, I'm using this option with https://github.com/nlewo/gremnix :) |
This prints the references graph of the store paths in the graphML
format [1]. The graphML format is supported by several graph tools
such as the Python Networkx library or the Apache Thinkerpop project.
I also wonder if this could replace the
--xmloutput since the GraphML format is well known and easy to manually parse.[1] http://graphml.graphdrawing.org