Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwupd: 1.1.2 -> 1.2.1 #48519

Merged
merged 2 commits into from Dec 13, 2018
Merged

fwupd: 1.1.2 -> 1.2.1 #48519

merged 2 commits into from Dec 13, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 16, 2018

https://github.com/hughsie/fwupd/blob/1.1.3/NEWS

Upgrade to 1.1.2 broke things but has known fix that should be landing soon--
this bump needs same fix so test appropriately. :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: fwupd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fwupd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/8yvqrjjsf0nyxdkwx8lgbpgxk5466nmi-fwupd-1.1.3-installedTests
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8yvqrjjsf0nyxdkwx8lgbpgxk5466nmi-fwupd-1.1.3-installedTests
checking for references to /build in /nix/store/8yvqrjjsf0nyxdkwx8lgbpgxk5466nmi-fwupd-1.1.3-installedTests...
Wrapping program /nix/store/5y1yq7i7nmmk7x8iw294asf7hbds72b1-fwupd-1.1.3/bin/fwupdmgr
Wrapping program /nix/store/5y1yq7i7nmmk7x8iw294asf7hbds72b1-fwupd-1.1.3/bin/dfu-tool
Wrapping program /nix/store/5y1yq7i7nmmk7x8iw294asf7hbds72b1-fwupd-1.1.3/libexec/fwupd/fwupd
Wrapping program /nix/store/5y1yq7i7nmmk7x8iw294asf7hbds72b1-fwupd-1.1.3/libexec/fwupd/fwupdate
Wrapping program /nix/store/5y1yq7i7nmmk7x8iw294asf7hbds72b1-fwupd-1.1.3/libexec/fwupd/fwupdtool
/nix/store/5y1yq7i7nmmk7x8iw294asf7hbds72b1-fwupd-1.1.3

@dtzWill
Copy link
Member Author

dtzWill commented Oct 16, 2018

cc #48427 (the PR mentioned above).

@jtojnar jtojnar changed the title fwupd: 1.1.2 -> 1.1.3 fwupd: 1.1.2 -> 1.2.0 Nov 10, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Nov 10, 2018

Updated, depends on #46020

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: libxmlb

The following builds were skipped because they don't evaluate on aarch64-linux: fwupd

Partial log (click to expand)

Build dir: /build/source/build
Build type: native build
WARNING: Unknown command line options: "auto_features"
This will become a hard error in a future Meson release.

meson.build:1:0: ERROR:  Meson version is 0.46.1 but project requires >=0.47.0.

A full log can be found at /build/source/build/meson-logs/meson-log.txt
builder for '/nix/store/b4617nnc7062152r5aqfni6pnpb1h9sc-libxmlb-0.1.4.drv' failed with exit code 1
error: build of '/nix/store/b4617nnc7062152r5aqfni6pnpb1h9sc-libxmlb-0.1.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: fwupd, libxmlb

Partial log (click to expand)


meson.build:1:0: ERROR:  Meson version is 0.46.1 but project requires >=0.47.0.

A full log can be found at /build/source/build/meson-logs/meson-log.txt
builder for '/nix/store/pbqjgm0rqczsz41lxlf6c3xaczqg4m8h-libxmlb-0.1.4.drv' failed with exit code 1
copying path '/nix/store/3wzy2k9ib6dfy78axhfqhc61qzgbvd7h-glib-networking-2.56.0' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/006fjpp880j2s334fgl00vq64w5bblkj-libproxy-0.4.15-dev' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/nicvm41jdz2mrfdmif7dznh2mmvk4a3y-glib-networking-2.56.0-dev' from 'https://nix-cache.s3.amazonaws.com'...
cannot build derivation '/nix/store/f690zqmk60v92bgz42alz6z46rgbj40x-fwupd-1.2.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/f690zqmk60v92bgz42alz6z46rgbj40x-fwupd-1.2.0.drv', '/nix/store/pbqjgm0rqczsz41lxlf6c3xaczqg4m8h-libxmlb-0.1.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: libxmlb

The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd

Partial log (click to expand)

Build dir: /private/tmp/nix-build-libxmlb-0.1.4.drv-0/source/build
Build type: native build
WARNING: Unknown command line options: "auto_features"
This will become a hard error in a future Meson release.

meson.build:1:0: ERROR:  Meson version is 0.46.1 but project requires >=0.47.0.

A full log can be found at /private/tmp/nix-build-libxmlb-0.1.4.drv-0/source/build/meson-logs/meson-log.txt
builder for '/nix/store/y05nrrhj6nb80h6zp7lf07nchbgnalmi-libxmlb-0.1.4.drv' failed with exit code 1
error: build of '/nix/store/y05nrrhj6nb80h6zp7lf07nchbgnalmi-libxmlb-0.1.4.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Nov 21, 2018

@GrahamcOfBorg build fwupd
@GrahamcOfBorg test fwupd

(not sure if tests pass currently, but let's see...)

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: fwupd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.fwupd

Partial log (click to expand)

Cannot nix-instantiate `tests.fwupd' because:
error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:347:27:
while evaluating the attribute 'fwupd' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/nixos/tests/all-tests.nix:77:3:
while evaluating 'handleTestOn' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/nixos/tests/all-tests.nix:19:33, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/nixos/tests/all-tests.nix:77:11:
access to path '/nix/store/6xd0ci2zzb3c0b11ki33vhk8wq1maljr-grahamc-aarch64-community-20' is forbidden in restricted mode

@dtzWill
Copy link
Member Author

dtzWill commented Nov 21, 2018

libxmlb 1.1.5 is out, do we want to include it as well?

@jtojnar
Copy link
Contributor

jtojnar commented Nov 21, 2018

Yup.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: fwupd

Partial log (click to expand)


meson.build:1:0: ERROR:  Meson version is 0.46.1 but project requires >=0.47.0.

A full log can be found at /build/source/build/meson-logs/meson-log.txt
builder for '/nix/store/35mqrbxnlah72s9jn7h8i7sgl1insn3f-libxmlb-0.1.4.drv' failed with exit code 1
copying path '/nix/store/3c5yqwrirqr0vijz88bji9iz0lpph5r7-glib-networking-2.56.0' from 'https://cache.nixos.org'...
copying path '/nix/store/w995pgjd7pn498x9vx3rb0z08261nhad-libproxy-0.4.15-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/s9av84m8jdvfv73d3xszx5riza52a9d3-glib-networking-2.56.0-dev' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/bjck5v5aw5d1mc7w4hz7psxz52lnqgsg-fwupd-1.2.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/bjck5v5aw5d1mc7w4hz7psxz52lnqgsg-fwupd-1.2.0.drv' failed

@jtojnar
Copy link
Contributor

jtojnar commented Nov 21, 2018

We need to wait for #50876

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.fwupd

Partial log (click to expand)

cannot link '/nix/store/.links/0c0vwmjcswdzm234zjffdlp45c9hk9yn8i4xcysnmb4id34h64bv' to '/nix/store/2yvljc4wa6jxcvwicp4acajfx1pswpfv-gleber-bastion/pkgs/os-specific/linux/spl/default.nix': No space left on device
error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/attrsets.nix:347:27:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/lists.nix:113:41, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/attrsets.nix:347:46:
while evaluating the attribute 'fwupd' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/nixos/tests/all-tests.nix:77:3:
while evaluating 'handleTestOn' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/nixos/tests/all-tests.nix:19:33, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/nixos/tests/all-tests.nix:77:11:
access to path '/nix/store/2yvljc4wa6jxcvwicp4acajfx1pswpfv-gleber-bastion' is forbidden in restricted mode

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: fwupd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@dtzWill
Copy link
Member Author

dtzWill commented Nov 21, 2018

Well FWIW bumping to 0.1.5 (and adding a python3 dependency, apparently) and rebasing onto staging -- produces a bunch of build errors that didn't seem obvious. My internet is being wonky or I'd be linking a branch/commit as well as logs, but anyway just a heads-up I suppose.

Oh hey managed to get the logs to gist anyway: https://gist.github.com/dtzWill/6412a806c9993ef01e1b4be4e20c938d

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: libxmlb

The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd

Partial log (click to expand)

Build dir: /private/tmp/nix-build-libxmlb-0.1.5.drv-0/source/build
Build type: native build
WARNING: Unknown command line options: "auto_features"
This will become a hard error in a future Meson release.

meson.build:1:0: ERROR:  Meson version is 0.46.1 but project requires >=0.47.0.

A full log can be found at /private/tmp/nix-build-libxmlb-0.1.5.drv-0/source/build/meson-logs/meson-log.txt
builder for '/nix/store/q5zm9nrss9qplmf3a4wvrryz83w819wv-libxmlb-0.1.5.drv' failed with exit code 1
error: build of '/nix/store/q5zm9nrss9qplmf3a4wvrryz83w819wv-libxmlb-0.1.5.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: fwupd, libxmlb

Partial log (click to expand)

A full log can be found at /build/source/build/meson-logs/meson-log.txt
builder for '/nix/store/yfa1daxgjag8bfi0sb9fv61ajiy49rch-libxmlb-0.1.5.drv' failed with exit code 1
building '/nix/store/sapbdikllbidvdpf92gya995qb4i3ih2-fwupd-1.2.1.tar.xz.drv'...

trying https://people.freedesktop.org/~hughsient/releases/fwupd-1.2.1.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1287k  100 1287k    0     0   959k      0  0:00:01  0:00:01 --:--:--  959k
cannot build derivation '/nix/store/2qr1p6ygh3zl42idjzbjnzmdsrvm5gp6-fwupd-1.2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2qr1p6ygh3zl42idjzbjnzmdsrvm5gp6-fwupd-1.2.1.drv', '/nix/store/yfa1daxgjag8bfi0sb9fv61ajiy49rch-libxmlb-0.1.5.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: libxmlb

The following builds were skipped because they don't evaluate on aarch64-linux: fwupd

Partial log (click to expand)

Build dir: /build/source/build
Build type: native build
WARNING: Unknown command line options: "auto_features"
This will become a hard error in a future Meson release.

meson.build:1:0: ERROR:  Meson version is 0.46.1 but project requires >=0.47.0.

A full log can be found at /build/source/build/meson-logs/meson-log.txt
builder for '/nix/store/4mib19izh87fs8i9yp6iyirbr53brkz4-libxmlb-0.1.5.drv' failed with exit code 1
error: build of '/nix/store/4mib19izh87fs8i9yp6iyirbr53brkz4-libxmlb-0.1.5.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: libxmlb

The following builds were skipped because they don't evaluate on aarch64-linux: fwupd

Partial log (click to expand)

Build dir: /build/source/build
Build type: native build
WARNING: Unknown command line options: "auto_features"
This will become a hard error in a future Meson release.

meson.build:1:0: ERROR:  Meson version is 0.46.1 but project requires >=0.47.0.

A full log can be found at /build/source/build/meson-logs/meson-log.txt
builder for '/nix/store/4mib19izh87fs8i9yp6iyirbr53brkz4-libxmlb-0.1.5.drv' failed with exit code 1
error: build of '/nix/store/4mib19izh87fs8i9yp6iyirbr53brkz4-libxmlb-0.1.5.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: libxmlb

The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd

Partial log (click to expand)

Build dir: /private/tmp/nix-build-libxmlb-0.1.5.drv-0/source/build
Build type: native build
WARNING: Unknown command line options: "auto_features"
This will become a hard error in a future Meson release.

meson.build:1:0: ERROR:  Meson version is 0.46.1 but project requires >=0.47.0.

A full log can be found at /private/tmp/nix-build-libxmlb-0.1.5.drv-0/source/build/meson-logs/meson-log.txt
builder for '/nix/store/q5zm9nrss9qplmf3a4wvrryz83w819wv-libxmlb-0.1.5.drv' failed with exit code 1
error: build of '/nix/store/q5zm9nrss9qplmf3a4wvrryz83w819wv-libxmlb-0.1.5.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: fwupd, libxmlb

Partial log (click to expand)

Build type: native build
WARNING: Unknown command line options: "auto_features"
This will become a hard error in a future Meson release.

meson.build:1:0: ERROR:  Meson version is 0.46.1 but project requires >=0.47.0.

A full log can be found at /build/source/build/meson-logs/meson-log.txt
builder for '/nix/store/yfa1daxgjag8bfi0sb9fv61ajiy49rch-libxmlb-0.1.5.drv' failed with exit code 1
cannot build derivation '/nix/store/ylm8qvaxy2fwm6iy4ygpgbw7mrc1carz-fwupd-1.2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/yfa1daxgjag8bfi0sb9fv61ajiy49rch-libxmlb-0.1.5.drv', '/nix/store/ylm8qvaxy2fwm6iy4ygpgbw7mrc1carz-fwupd-1.2.1.drv' failed

@jtojnar
Copy link
Contributor

jtojnar commented Nov 30, 2018

@GrahamcOfBorg build fwupd

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: fwupd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fwupd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fwupd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/3j6lnhncma5a5zd2irz5pzcrmjzarlpn-fwupd-1.2.1-installedTests
strip is /nix/store/6s8dkfj3irwv52cap2hd9k7gaddklfs1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3j6lnhncma5a5zd2irz5pzcrmjzarlpn-fwupd-1.2.1-installedTests
checking for references to /build/ in /nix/store/3j6lnhncma5a5zd2irz5pzcrmjzarlpn-fwupd-1.2.1-installedTests...
Wrapping program /nix/store/vxcp502g1r6vjjh0kz0hdp81s2qfgk5k-fwupd-1.2.1/bin/dfu-tool
Wrapping program /nix/store/vxcp502g1r6vjjh0kz0hdp81s2qfgk5k-fwupd-1.2.1/bin/fwupdmgr
Wrapping program /nix/store/vxcp502g1r6vjjh0kz0hdp81s2qfgk5k-fwupd-1.2.1/libexec/fwupd/fwupdate
Wrapping program /nix/store/vxcp502g1r6vjjh0kz0hdp81s2qfgk5k-fwupd-1.2.1/libexec/fwupd/fwupd
Wrapping program /nix/store/vxcp502g1r6vjjh0kz0hdp81s2qfgk5k-fwupd-1.2.1/libexec/fwupd/fwupdtool
/nix/store/vxcp502g1r6vjjh0kz0hdp81s2qfgk5k-fwupd-1.2.1

@jtojnar
Copy link
Contributor

jtojnar commented Nov 30, 2018

I guess we should squash the commits.

@worldofpeace
Copy link
Contributor

@jtojnar @dtzWill

I've resolved the conflicts, corrected the commit msg, etc.
I hope you don't mind 😅

];

LC_ALL = "en_US.UTF-8"; # For po/make-images

patches = [
./fix-paths.patch
./add-option-for-installation-sysconfdir.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought this patch in tree because, IIRC, the url before wouldn't have been stable.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 13, 2018

@GrahamcOfBorg test fwupd

@worldofpeace
Copy link
Contributor

Failed locally for me with

Installing test firmware...
Decompressing…         [***************************************]
failed to add public keys to gpgme-v1.12.0 keyring: failed to load /etc/pki/fwupd/GPG-KEY-Linux-Foundation-Metadata: No such file or directory
FAIL: fwupd/fwupdmgr.test (Child process exited with code 1)
error: Attempt to end element "line" with "nest" tag at /nix/store/vpm0bbgi88jj52sq9kfnpif5jrmqxcr9-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 53.
Attempt to end element "line" with "nest" tag at /nix/store/vpm0bbgi88jj52sq9kfnpif5jrmqxcr9-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 53.
cleaning up
killing machine (pid 597)
Attempt to end element "line" with "logfile" tag at /nix/store/vpm0bbgi88jj52sq9kfnpif5jrmqxcr9-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 27.
END failed--call queue aborted, <__ANONIO__> line 98.
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/3ac86f46d96zyjpsvqa5nyq0adsij4jl-vm-test-run-fwupd.drv' failed with exit code 22
error: build of '/nix/store/3ac86f46d96zyjpsvqa5nyq0adsij4jl-vm-test-run-fwupd.drv' failed

@worldofpeace
Copy link
Contributor

Test succeeds locally, and I double checked filesInstalledToEtc.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 13, 2018

Something to keep in mind for next update: fwupd/fwupd#865

Add cairo dep and others checked for
in fwupd's meson.build.

Cairo at least is required.
@worldofpeace
Copy link
Contributor

I think everything looks good. Lets go for it 👍

@worldofpeace worldofpeace merged commit b7fbde8 into NixOS:master Dec 13, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Dec 18, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants