cpplint: init at 1.3.0 #47836

bhipple · 2018-10-04T01:26:19Z

Static analyzer for C++ code. Licensed under a very permissive, generic Google license.

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

bhipple · 2018-10-04T01:26:39Z

@GrahamcOfBorg build cpplint

GrahamcOfBorg · 2018-10-04T01:26:59Z

Failure on aarch64-linux (full log)

Attempted: cpplint

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/46kggqmhymhxw3yghab9qrxdd6s19ivb-cpplint-1.3.0
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/46kggqmhymhxw3yghab9qrxdd6s19ivb-cpplint-1.3.0/lib  /nix/store/46kggqmhymhxw3yghab9qrxdd6s19ivb-cpplint-1.3.0/bin
patching script interpreter paths in /nix/store/46kggqmhymhxw3yghab9qrxdd6s19ivb-cpplint-1.3.0
checking for references to /build in /nix/store/46kggqmhymhxw3yghab9qrxdd6s19ivb-cpplint-1.3.0...
wrapping `/nix/store/46kggqmhymhxw3yghab9qrxdd6s19ivb-cpplint-1.3.0/bin/cpplint'...
running install tests
/nix/store/fih47c6k33lkf0hblsfg1dyp05kw22xa-stdenv-linux/setup: ./cpplint_unittest.py: /usr/bin/env: bad interpreter: No such file or directory
builder for '/nix/store/hwf5vd0gf6a00q2x8mmzvfilki76qjyv-cpplint-1.3.0.drv' failed with exit code 126
error: build of '/nix/store/hwf5vd0gf6a00q2x8mmzvfilki76qjyv-cpplint-1.3.0.drv' failed

GrahamcOfBorg · 2018-10-04T01:27:22Z

Failure on x86_64-linux (full log)

Attempted: cpplint

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/l9gwhja5lzmw8d5phmfpadj661s2dqvb-cpplint-1.3.0
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l9gwhja5lzmw8d5phmfpadj661s2dqvb-cpplint-1.3.0/lib  /nix/store/l9gwhja5lzmw8d5phmfpadj661s2dqvb-cpplint-1.3.0/bin
patching script interpreter paths in /nix/store/l9gwhja5lzmw8d5phmfpadj661s2dqvb-cpplint-1.3.0
checking for references to /build in /nix/store/l9gwhja5lzmw8d5phmfpadj661s2dqvb-cpplint-1.3.0...
wrapping `/nix/store/l9gwhja5lzmw8d5phmfpadj661s2dqvb-cpplint-1.3.0/bin/cpplint'...
running install tests
/nix/store/2hjlb5wim3ghl2p1r65bb49y06ckd3g1-stdenv-linux/setup: ./cpplint_unittest.py: /usr/bin/env: bad interpreter: No such file or directory
builder for '/nix/store/mk0hj530mgsjfbs4iq4drn950xix9nwf-cpplint-1.3.0.drv' failed with exit code 126
error: build of '/nix/store/mk0hj530mgsjfbs4iq4drn950xix9nwf-cpplint-1.3.0.drv' failed

GrahamcOfBorg · 2018-10-04T01:48:16Z

Success on aarch64-linux (full log)

Attempted: cpplint

Partial log (click to expand)

wrapping `/nix/store/f7n505ihj5d1k954n3b8f3fqz76iaw74-cpplint-1.3.0/bin/cpplint'...
running install tests
................................................................................/cpplint_unittest.py:96: DeprecationWarning: Please use assertTrue instead.
  ' which is not in _ERROR_CATEGORIES' % (message, category))
........................................................................................................
----------------------------------------------------------------------
Ran 183 tests in 1.747s

OK
/nix/store/f7n505ihj5d1k954n3b8f3fqz76iaw74-cpplint-1.3.0

GrahamcOfBorg · 2018-10-04T01:48:51Z

Success on x86_64-linux (full log)

Attempted: cpplint

Partial log (click to expand)

wrapping `/nix/store/mcpr6rl1v86l8axm2fzk7ka5jjcrn21m-cpplint-1.3.0/bin/cpplint'...
running install tests
................................................................................/cpplint_unittest.py:96: DeprecationWarning: Please use assertTrue instead.
  ' which is not in _ERROR_CATEGORIES' % (message, category))
........................................................................................................
----------------------------------------------------------------------
Ran 183 tests in 0.849s

OK
/nix/store/mcpr6rl1v86l8axm2fzk7ka5jjcrn21m-cpplint-1.3.0

bhipple · 2018-10-04T02:42:50Z

CC @grahamc this bot is awesome. It just caught an issue where it "worked on my machine" but would've failed after the fact on Hydra / NixOS, and saved me or a frustrated user some debugging time 👍

grahamc · 2018-10-04T02:55:21Z

🐱 🙌 🎉

bhipple · 2018-10-04T15:23:30Z

CC @FRidh for python review

FRidh · 2018-10-09T13:43:15Z

pkgs/development/tools/analysis/cpplint/default.nix

+    homepage = https://github.com/cpplint/cpplint;
+    description = "Static code checker for C++";
+    maintainers = [ maintainers.bhipple ];
+    license = [ licenses.free ];


Is this license correct?

FRidh · 2018-10-09T13:44:30Z

pkgs/development/tools/analysis/cpplint/default.nix

@@ -0,0 +1,29 @@
+{ lib, buildPythonApplication, fetchFromGitHub }:


This is not a Python library, so pass in python or pythonPackages and use its attributes (buildPythonApplication).

bhipple · 2018-10-09T19:43:55Z

Thanks @FRidh! Updated accordingly. The license is here:
https://github.com/cpplint/cpplint/blob/master/LICENSE

I don't think this is a specific license, which is why I just put licenses.free, but if there's a better one I'm happy to iterate further.

GrahamcOfBorg · 2018-10-09T19:58:50Z

Success on x86_64-linux (full log)

Attempted: cpplint

Partial log (click to expand)

patching script interpreter paths in /nix/store/59159d08wbrj0h5yd9hg8qrd1ipia5w3-cpplint-1.3.0
checking for references to /build in /nix/store/59159d08wbrj0h5yd9hg8qrd1ipia5w3-cpplint-1.3.0...
wrapping `/nix/store/59159d08wbrj0h5yd9hg8qrd1ipia5w3-cpplint-1.3.0/bin/cpplint'...
running install tests
.......................................................................................................................................................................................
----------------------------------------------------------------------
Ran 183 tests in 0.748s

OK
/nix/store/59159d08wbrj0h5yd9hg8qrd1ipia5w3-cpplint-1.3.0

GrahamcOfBorg · 2018-10-09T19:59:03Z

Success on aarch64-linux (full log)

Attempted: cpplint

Partial log (click to expand)

patching script interpreter paths in /nix/store/9xrjq0rxsvhg3rr8377l2853kc0rpj71-cpplint-1.3.0
checking for references to /build in /nix/store/9xrjq0rxsvhg3rr8377l2853kc0rpj71-cpplint-1.3.0...
wrapping `/nix/store/9xrjq0rxsvhg3rr8377l2853kc0rpj71-cpplint-1.3.0/bin/cpplint'...
running install tests
.......................................................................................................................................................................................
----------------------------------------------------------------------
Ran 183 tests in 1.459s

OK
/nix/store/9xrjq0rxsvhg3rr8377l2853kc0rpj71-cpplint-1.3.0

c0bw3b · 2018-10-11T17:34:12Z

@bhipple this license text is actually the BSD 3-clause wording.
So you should rather set licenses.bsd3

bhipple · 2018-10-11T19:59:29Z

Aha, thanks!

GrahamcOfBorg · 2018-10-11T20:12:27Z

Success on x86_64-linux (full log)

Attempted: cpplint

Partial log (click to expand)

patching script interpreter paths in /nix/store/59159d08wbrj0h5yd9hg8qrd1ipia5w3-cpplint-1.3.0
checking for references to /build in /nix/store/59159d08wbrj0h5yd9hg8qrd1ipia5w3-cpplint-1.3.0...
wrapping `/nix/store/59159d08wbrj0h5yd9hg8qrd1ipia5w3-cpplint-1.3.0/bin/cpplint'...
running install tests
.......................................................................................................................................................................................
----------------------------------------------------------------------
Ran 183 tests in 0.748s

OK
/nix/store/59159d08wbrj0h5yd9hg8qrd1ipia5w3-cpplint-1.3.0

GrahamcOfBorg · 2018-10-11T20:12:41Z

Success on aarch64-linux (full log)

Attempted: cpplint

Partial log (click to expand)

patching script interpreter paths in /nix/store/9xrjq0rxsvhg3rr8377l2853kc0rpj71-cpplint-1.3.0
checking for references to /build in /nix/store/9xrjq0rxsvhg3rr8377l2853kc0rpj71-cpplint-1.3.0...
wrapping `/nix/store/9xrjq0rxsvhg3rr8377l2853kc0rpj71-cpplint-1.3.0/bin/cpplint'...
running install tests
.......................................................................................................................................................................................
----------------------------------------------------------------------
Ran 183 tests in 1.449s

OK
/nix/store/9xrjq0rxsvhg3rr8377l2853kc0rpj71-cpplint-1.3.0

Static analyzer for C++ code. Licensed under a very permissive, generic Google license (BSD3 wording).

bhipple · 2018-10-12T18:52:37Z

I rebased and squashed up my commits to keep the history clean after implementing all the code review changes.

GrahamcOfBorg · 2018-10-12T19:10:41Z

Success on x86_64-linux (full log)

Attempted: cpplint

Partial log (click to expand)

patching script interpreter paths in /nix/store/xqb2cnd8axxjczv98priw4q0yjkbql01-cpplint-1.3.0
checking for references to /build in /nix/store/xqb2cnd8axxjczv98priw4q0yjkbql01-cpplint-1.3.0...
wrapping `/nix/store/xqb2cnd8axxjczv98priw4q0yjkbql01-cpplint-1.3.0/bin/cpplint'...
running install tests
.......................................................................................................................................................................................
----------------------------------------------------------------------
Ran 183 tests in 0.752s

OK
/nix/store/xqb2cnd8axxjczv98priw4q0yjkbql01-cpplint-1.3.0

GrahamcOfBorg · 2018-10-12T19:10:56Z

Success on aarch64-linux (full log)

Attempted: cpplint

Partial log (click to expand)

patching script interpreter paths in /nix/store/vd2dmchv9r5gqla1ssyd1nlm2hdzwqhg-cpplint-1.3.0
checking for references to /build in /nix/store/vd2dmchv9r5gqla1ssyd1nlm2hdzwqhg-cpplint-1.3.0...
wrapping `/nix/store/vd2dmchv9r5gqla1ssyd1nlm2hdzwqhg-cpplint-1.3.0/bin/cpplint'...
running install tests
.......................................................................................................................................................................................
----------------------------------------------------------------------
Ran 183 tests in 1.463s

OK
/nix/store/vd2dmchv9r5gqla1ssyd1nlm2hdzwqhg-cpplint-1.3.0

bhipple force-pushed the add/cpplint branch from 91838e7 to 8723c9f Compare October 4, 2018 01:36

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 4, 2018

FRidh reviewed Oct 9, 2018

View reviewed changes

FRidh requested changes Oct 9, 2018

View reviewed changes

bhipple mentioned this pull request Oct 9, 2018

luigi: init at 2.7.9 #47893

Merged

9 tasks

cpplint: init at 1.3.0

964214b

Static analyzer for C++ code. Licensed under a very permissive, generic Google license (BSD3 wording).

bhipple force-pushed the add/cpplint branch from 77d921b to 964214b Compare October 12, 2018 18:52

c0bw3b merged commit 7a90980 into NixOS:master Oct 12, 2018

bhipple deleted the add/cpplint branch February 27, 2019 23:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cpplint: init at 1.3.0 #47836

cpplint: init at 1.3.0 #47836

bhipple commented Oct 4, 2018 •

edited

bhipple commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

bhipple commented Oct 4, 2018

grahamc commented Oct 4, 2018

bhipple commented Oct 4, 2018

FRidh Oct 9, 2018

FRidh Oct 9, 2018

bhipple commented Oct 9, 2018

GrahamcOfBorg commented Oct 9, 2018

GrahamcOfBorg commented Oct 9, 2018

c0bw3b commented Oct 11, 2018

bhipple commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

bhipple commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

		@@ -0,0 +1,29 @@
		{ lib, buildPythonApplication, fetchFromGitHub }:

cpplint: init at 1.3.0 #47836

cpplint: init at 1.3.0 #47836

Conversation

bhipple commented Oct 4, 2018 • edited

Motivation for this change

Things done

bhipple commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

bhipple commented Oct 4, 2018

grahamc commented Oct 4, 2018

bhipple commented Oct 4, 2018

FRidh Oct 9, 2018

Choose a reason for hiding this comment

FRidh Oct 9, 2018

Choose a reason for hiding this comment

bhipple commented Oct 9, 2018

GrahamcOfBorg commented Oct 9, 2018

GrahamcOfBorg commented Oct 9, 2018

c0bw3b commented Oct 11, 2018

bhipple commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

bhipple commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

bhipple commented Oct 4, 2018 •

edited