Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mhwaveedit: 1.4.23 -> 1.4.24 #47808

Merged
merged 1 commit into from Oct 3, 2018
Merged

mhwaveedit: 1.4.23 -> 1.4.24 #47808

merged 1 commit into from Oct 3, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 3, 2018

Motivation for this change

Package refresh
+ moved pkgconfig and makeWrapper to nativeBuildInputs
+ fixed fetcher
+ fixed meta.homepage since Gna.org forge is closed

Follow-up to #32205

It builds and runs on NixOS 18.09-beta
cc @cillianderoiste for review

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
mhwaveedit: 1.4.23 -> 1.4.24
63ed869 
+ moved pkgconfig and makeWrapper to nativeBuildInputs
+ fixed fetcher
+ fixed meta.homepage
@c0bw3b c0bw3b mentioned this pull request Oct 3, 2018
Open
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mhwaveedit

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j6af2pn8kl2wg3kdw870dwjgsxazi3fh-mhwaveedit-1.4.24
shrinking /nix/store/j6af2pn8kl2wg3kdw870dwjgsxazi3fh-mhwaveedit-1.4.24/bin/.mhwaveedit-wrapped
gzipping man pages under /nix/store/j6af2pn8kl2wg3kdw870dwjgsxazi3fh-mhwaveedit-1.4.24/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j6af2pn8kl2wg3kdw870dwjgsxazi3fh-mhwaveedit-1.4.24/bin
patching script interpreter paths in /nix/store/j6af2pn8kl2wg3kdw870dwjgsxazi3fh-mhwaveedit-1.4.24
checking for references to /build in /nix/store/j6af2pn8kl2wg3kdw870dwjgsxazi3fh-mhwaveedit-1.4.24...
/nix/store/j6af2pn8kl2wg3kdw870dwjgsxazi3fh-mhwaveedit-1.4.24

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mhwaveedit

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sv5b93ngxnr1bmbb088pg8bq8idz1vkc-mhwaveedit-1.4.24
shrinking /nix/store/sv5b93ngxnr1bmbb088pg8bq8idz1vkc-mhwaveedit-1.4.24/bin/.mhwaveedit-wrapped
gzipping man pages under /nix/store/sv5b93ngxnr1bmbb088pg8bq8idz1vkc-mhwaveedit-1.4.24/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sv5b93ngxnr1bmbb088pg8bq8idz1vkc-mhwaveedit-1.4.24/bin
patching script interpreter paths in /nix/store/sv5b93ngxnr1bmbb088pg8bq8idz1vkc-mhwaveedit-1.4.24
checking for references to /build in /nix/store/sv5b93ngxnr1bmbb088pg8bq8idz1vkc-mhwaveedit-1.4.24...
/nix/store/sv5b93ngxnr1bmbb088pg8bq8idz1vkc-mhwaveedit-1.4.24

@Mic92 Mic92 merged commit 6c4ed96 into NixOS:master Oct 3, 2018
@c0bw3b c0bw3b deleted the pkg/mhwaveedit branch October 6, 2018 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @GrahamcOfBorg @Mic92