Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoin: 0.16.3 -> 0.17.0 #47855

Merged
merged 2 commits into from Oct 5, 2018
Merged

Bitcoin: 0.16.3 -> 0.17.0 #47855

merged 2 commits into from Oct 5, 2018

Conversation

roconnor
Copy link
Contributor

@roconnor roconnor commented Oct 4, 2018

Motivation for this change

Updating to latest Bitcoin release.

I've also fixed doCheck to work with bitcoin-qt and enabled it by default, which partly reverts #47258.

Sorry @dtzWill, but I prefer checks to be enabled for Bitcoin. We are not necessarily using the same compiler flags nor the exact build dependencies that upstream is using when they release Bitcoin, so having checks it place could be useful in catching critical errors from being introduced by our slightly adhoc build process. Bitcoin is especially critical software in that software errors could cause people to permanently lose funds; we want to do everything we can to guard against that happening.

However, doCheck is now a parameter to the derivation, which should make it easy to override for anyone who wants to disable the checks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jb55 Would you like to review?

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bitcoin

Partial log (click to expand)

shrinking /nix/store/qd0ag89y0h9i9g234r480bws1f6i63hi-bitcoin-0.17.0/bin/bitcoin-cli
shrinking /nix/store/qd0ag89y0h9i9g234r480bws1f6i63hi-bitcoin-0.17.0/bin/bitcoind
shrinking /nix/store/qd0ag89y0h9i9g234r480bws1f6i63hi-bitcoin-0.17.0/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/qd0ag89y0h9i9g234r480bws1f6i63hi-bitcoin-0.17.0/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qd0ag89y0h9i9g234r480bws1f6i63hi-bitcoin-0.17.0/lib  /nix/store/qd0ag89y0h9i9g234r480bws1f6i63hi-bitcoin-0.17.0/bin
patching script interpreter paths in /nix/store/qd0ag89y0h9i9g234r480bws1f6i63hi-bitcoin-0.17.0
checking for references to /build in /nix/store/qd0ag89y0h9i9g234r480bws1f6i63hi-bitcoin-0.17.0...
postPatchMkspecs
/nix/store/qd0ag89y0h9i9g234r480bws1f6i63hi-bitcoin-0.17.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bitcoin

Partial log (click to expand)

shrinking /nix/store/7ywlh6wgj6asidmnsz15fghqcg8h2knx-bitcoin-0.17.0/bin/bitcoin-cli
shrinking /nix/store/7ywlh6wgj6asidmnsz15fghqcg8h2knx-bitcoin-0.17.0/bin/bitcoin-qt
shrinking /nix/store/7ywlh6wgj6asidmnsz15fghqcg8h2knx-bitcoin-0.17.0/bin/bitcoin-tx
gzipping man pages under /nix/store/7ywlh6wgj6asidmnsz15fghqcg8h2knx-bitcoin-0.17.0/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7ywlh6wgj6asidmnsz15fghqcg8h2knx-bitcoin-0.17.0/lib  /nix/store/7ywlh6wgj6asidmnsz15fghqcg8h2knx-bitcoin-0.17.0/bin
patching script interpreter paths in /nix/store/7ywlh6wgj6asidmnsz15fghqcg8h2knx-bitcoin-0.17.0
checking for references to /build in /nix/store/7ywlh6wgj6asidmnsz15fghqcg8h2knx-bitcoin-0.17.0...
postPatchMkspecs
/nix/store/7ywlh6wgj6asidmnsz15fghqcg8h2knx-bitcoin-0.17.0

@dtzWill
Copy link
Member

dtzWill commented Oct 4, 2018

They were already disabled, I just disabled building tests that weren't being executed. At least that was my intention. But if they can be enabled and such that sounds great to me!

@roconnor
Copy link
Contributor Author

roconnor commented Oct 4, 2018

@dtzWill Cool. Do you think I should remove doCheck as a parameter and just set doCheck = true?

@jb55
Copy link
Contributor

jb55 commented Oct 4, 2018 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

I've verified that the hash

  0pkq28d2dj22qrxyyg9kh0whmhj7ghyabnhyqldbljv4a7l3kvwq

aka

  98ef39e851644bba1ac51edaa53c7c47c20a3980333def7bc642c8261a12785e

Corresponds to the hash in SHA256SUMS.asc signed by the bitcoin core binary
release key:

$ sha256sum --check --ignore-missing SHA256SUMS.asc
bitcoin-0.17.0.tar.gz: OK

$ gpg --verify SHA256SUMS.asc
gpg: Signature made 2018-10-03T01:53:25 PDT
gpg:                using RSA key 90C8019E36C2E964
gpg: Good signature from "Wladimir J. van der Laan (Bitcoin Core binary release signing key) <laanwj@gmail.com>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 01EA 5486 DE18 A882 D4C2  6845 90C8 019E 36C2 E964
-----BEGIN PGP SIGNATURE-----

iIQEARYKACwWIQRbKx5PYiFrx0NirGHU+6L8RTWiqQUCW7alNg4camI1NUBqYjU1
LmNvbQAKCRDU+6L8RTWiqdaLAQDM70UqlLzFiTms/mfG4ee8mLUsYUflTgyyKt39
0cGWWQEAzi1IYjGp8OgoaZoeUyroy+UORtV2evxx7qxgNHIShAw=
=jyqq
-----END PGP SIGNATURE-----

I've signed this with my HSM key listed on my website: https://jb55.com/pgp.txt

ACK 8260af418d1089eb51594585d2d103cfe1140d3a

@roconnor
bitcoin: enable doCheck
ef0f1eb 
Fixes checkPhase for bitcoin-qt.
@roconnor
Copy link
Contributor Author

roconnor commented Oct 5, 2018

I've gone ahead and just set doCheck = true. If there is demand we can have another PR to make doCheck a parameter.

@roconnor roconnor merged commit 8a4a732 into NixOS:master Oct 5, 2018
@roconnor roconnor deleted the bitcoin branch October 5, 2018 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roconnor @GrahamcOfBorg @dtzWill @jb55