tree-wide: /var/run -> /run [WIP] #47856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Oct 4, 2018
There was a problem hiding this comment.
From man shells(5):
/etc/shells is a text file which contains the full pathnames of valid
login shells. This file is consulted by chsh(1) and available to be
queried by other programs.
Be aware that there are programs which consult this file to find out if
a user is a normal user; for example, FTP daemons traditionally disal‐
low access to users with shells not included in this file.
This could lock out users that have the old /var/run right?
| @@ -218,9 +218,9 @@ in | |||
|
|
|||
| environment.shells = | |||
| [ "/run/current-system/sw/bin/bash" | |||
| "/var/run/current-system/sw/bin/bash" | |||
| "/run/current-system/sw/bin/bash" | |||
| "/run/current-system/sw/bin/sh" | ||
| "/var/run/current-system/sw/bin/sh" |
| @@ -176,7 +176,7 @@ in | |||
|
|
|||
| environment.shells = [ | |||
| "/run/current-system/sw/bin/fish" | |||
| "/var/run/current-system/sw/bin/fish" | |||
| "/run/current-system/sw/bin/fish" | |||
| @@ -50,7 +50,7 @@ in | |||
|
|
|||
| environment.shells = | |||
| [ "/run/current-system/sw/bin/xonsh" | |||
| "/var/run/current-system/sw/bin/xonsh" | |||
| "/run/current-system/sw/bin/xonsh" | |||
| @@ -201,7 +201,7 @@ in | |||
|
|
|||
| environment.shells = | |||
| [ "/run/current-system/sw/bin/zsh" | |||
| "/var/run/current-system/sw/bin/zsh" | |||
| "/run/current-system/sw/bin/zsh" | |||
|
Thanks for the comprehensive review @volth - I'll clear it all up. |
peterhoeg
changed the title
worldofpeace
reviewed
Oct 4, 2018
| @@ -6,7 +6,7 @@ index 16b80f7..b3af435 100644 | |||
| #guest-account-script=guest-account | |||
| #logind-check-graphical=false | |||
| #log-directory=/var/log/lightdm | |||
| -#run-directory=/var/run/lightdm | |||
| -#run-directory=/run/lightdm | |||
| +run-directory=/run/lightdm | |||
There was a problem hiding this comment.
I already did this
9 tasks
10 tasks
|
When the conflicts are resolved, is this PR still WIP? |
|
See https://github.com/bobvanderlinden/nixpkgs/tree/var-run
What is the next step into getting this merged? |
|
@bobvanderlinden, please open a new PR with your changes and reference this one. I'll go ahead and close this afterwards. |
10 tasks
|
I have a new PR ready. Could you also give it a review @peterhoeg ? This PR contains quite a few changes that can be problematic. I've removed those from #51918 |
|
Superseeded |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
/var/run/is deprecated in favour of/run.Further to #47775
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)