Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

khard: fixup zsh autocompletion #47854

Merged
merged 1 commit into from Oct 4, 2018
Merged

khard: fixup zsh autocompletion #47854

merged 1 commit into from Oct 4, 2018

Conversation

teto
Copy link
Member

@teto teto commented Oct 4, 2018 •
edited

I introduced an error in #46515:

/build/khard-0.12.2
install: target '/nix/store/f8awiqmsici77awywp64j3prr29ij9lk-python3.6-khard-0.12.2/share/zsh/site-functions/' is not a directory: No such file or directory
note: keeping build directory '/tmp/nix-build-python3.6-khard-0.12.2.drv-0'

install -D will create the folders until the last component excluded so I needed to add the filename for it to create the site-functions/ folder.

I had tested it and clearly remembers completion working. I must have messed up somewhere sorry for the inconvenience.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@teto
khard: fixup zsh autocompletion
e30a2b0 
I introduced an error in, install -D will create the folders until the last component excluded
so I needed to add the filename for it to create _khard
NixOS#46515
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: khard

Partial log (click to expand)

Successfully installed khard-0.12.2
/build/khard-0.12.2
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c5rl4n89wzmgqpf95jswxwpyd9v5na8n-khard-0.12.2
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c5rl4n89wzmgqpf95jswxwpyd9v5na8n-khard-0.12.2/lib  /nix/store/c5rl4n89wzmgqpf95jswxwpyd9v5na8n-khard-0.12.2/bin
patching script interpreter paths in /nix/store/c5rl4n89wzmgqpf95jswxwpyd9v5na8n-khard-0.12.2
checking for references to /build in /nix/store/c5rl4n89wzmgqpf95jswxwpyd9v5na8n-khard-0.12.2...
wrapping `/nix/store/c5rl4n89wzmgqpf95jswxwpyd9v5na8n-khard-0.12.2/bin/khard'...
/nix/store/c5rl4n89wzmgqpf95jswxwpyd9v5na8n-khard-0.12.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: khard

Partial log (click to expand)

Successfully installed khard-0.12.2
/build/khard-0.12.2
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rxkibj29cs3ymd2cnw9agx4f3wvagm0m-khard-0.12.2
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rxkibj29cs3ymd2cnw9agx4f3wvagm0m-khard-0.12.2/lib  /nix/store/rxkibj29cs3ymd2cnw9agx4f3wvagm0m-khard-0.12.2/bin
patching script interpreter paths in /nix/store/rxkibj29cs3ymd2cnw9agx4f3wvagm0m-khard-0.12.2
checking for references to /build in /nix/store/rxkibj29cs3ymd2cnw9agx4f3wvagm0m-khard-0.12.2...
wrapping `/nix/store/rxkibj29cs3ymd2cnw9agx4f3wvagm0m-khard-0.12.2/bin/khard'...
/nix/store/rxkibj29cs3ymd2cnw9agx4f3wvagm0m-khard-0.12.2

@Mic92
Copy link
Member

Mic92 commented Oct 4, 2018

@GrahamcOfBorg build khard

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: khard

Partial log (click to expand)

/nix/store/c5rl4n89wzmgqpf95jswxwpyd9v5na8n-khard-0.12.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: khard

Partial log (click to expand)

  The script khard is installed in '/nix/store/7bs0nxds62d4fphmx5lw1pf1sxwl2cka-khard-0.12.2/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed khard-0.12.2
/private/tmp/nix-build-khard-0.12.2.drv-0/khard-0.12.2
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7bs0nxds62d4fphmx5lw1pf1sxwl2cka-khard-0.12.2/lib  /nix/store/7bs0nxds62d4fphmx5lw1pf1sxwl2cka-khard-0.12.2/bin
patching script interpreter paths in /nix/store/7bs0nxds62d4fphmx5lw1pf1sxwl2cka-khard-0.12.2
wrapping `/nix/store/7bs0nxds62d4fphmx5lw1pf1sxwl2cka-khard-0.12.2/bin/khard'...
/nix/store/7bs0nxds62d4fphmx5lw1pf1sxwl2cka-khard-0.12.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: khard

Partial log (click to expand)

/nix/store/rxkibj29cs3ymd2cnw9agx4f3wvagm0m-khard-0.12.2

@Mic92 Mic92 merged commit 665da39 into NixOS:master Oct 4, 2018
@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Oct 4, 2018 •
edited

Ran into the same issue, awesome that it is already reported (and fixed)!

❤️

@teto teto deleted the khard_zsh branch May 13, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teto @GrahamcOfBorg @Mic92 @matthiasbeyer