Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP liquidsoap update #47834

Closed
wants to merge 1 commit into from
Closed

WIP liquidsoap update #47834

wants to merge 1 commit into from

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 4, 2018 •
edited

Motivation for this change

Doesn't compile yet; I'm hoping someone can fix it...
cc @ehmry @whohoho

Needs #47833

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@tg-x
Copy link
Member

tg-x commented Oct 5, 2018 •
edited

@magnetophon see fixes in tg-x@f6bce7e

builds now, runs, seems to work

@tg-x tg-x mentioned this pull request Oct 8, 2018
Merged
9 tasks
@tg-x
Copy link
Member

tg-x commented Oct 8, 2018

created a new PR with the fixes, see above

@magnetophon
Copy link
Member Author

@tg-x Thanks!

@magnetophon magnetophon closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @tg-x @GrahamcOfBorg