Add download count column to GUI #2518
Merged
+91
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
KSP-CKAN/NetKAN-bot#67 created a script that updates a download_counts.json file in CKAN-meta containing the download counts of mods. This data is available now (and already being downloaded whenever anyone clicks Refresh!), but it's not being used yet.
Changes
Now when you refresh the registry, we extract the
download_counts.json
file and parse it, then store the values it contains in a dictionary atRegistry.download_counts
.A new Downloads column is added to GUI displaying this value for each mod. The user can sort this column to identify major mods that they haven't tried before.
Congrats to KIS for winning the popularity contest:Correction: Congrats to EVE for winning the popularity contest (now that KSP-CKAN/NetKAN-bot#73 is counting older branches):
Fixes #2415.