Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile-sync-daemon: add missing path to systemd service #48006

Merged
merged 1 commit into from Oct 14, 2018

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Oct 7, 2018

When using psd in OverlayFS mode, it can't find some binaries it needs (e.g. mountpoint), resulting in sync failures (even though it reports success)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Can you change the commit message to have the nixos/profile-sync-daemon prefix? Other than that this looks good to me :)

@NickHu
Copy link
Contributor Author

NickHu commented Oct 14, 2018

@infinisil Done!

@infinisil infinisil merged commit 0ea6409 into NixOS:master Oct 14, 2018
@NickHu NickHu deleted the psd branch October 14, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants