Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fish: use 'escapeShellArg' for shell aliases #48026

Merged
merged 1 commit into from Oct 11, 2018
Merged

nixos/fish: use 'escapeShellArg' for shell aliases #48026

merged 1 commit into from Oct 11, 2018

Conversation

mnacamura
Copy link
Contributor

@mnacamura mnacamura commented Oct 8, 2018 •
edited

Motivation for this change

Follow #47471 and #47984.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

Just to be sure: you've verified that the escaping makes sense for fish syntax? (I have no clue, sorry if this is a dumb question).

infinisil
infinisil approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joachifm Yeah, while I don't use fish, it seems to have the same escaping as bash/zsh, did a quick check

@infinisil infinisil merged commit a232e5f into NixOS:master Oct 11, 2018
@mnacamura mnacamura deleted the fish-escapeshellarg branch October 12, 2018 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnacamura @joachifm @infinisil @GrahamcOfBorg