Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nano: 3.0 -> 3.1 #47991

Merged
merged 1 commit into from Oct 7, 2018
Merged

nano: 3.0 -> 3.1 #47991

merged 1 commit into from Oct 7, 2018

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Oct 7, 2018

Motivation for this change

GNU nano 3.1 [...] fixes a misbinding of ^H on some terminals and some systems.
— https://www.nano-editor.org/news.php

This was pointed out to me earlier today by a friend testing NixOS 18.09; in the installer image right now backspacing backspaces whole words!

I have verified that on a linux terminal (CTRL+ALT+F1) the behaviour is now as expected.

Yes, this'll need a backport to 18.09!

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • ⬜ macOS
    • ⬜ other Linux distributions
  • ⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • ✔️ Tested execution of all binary files (usually in ./result/bin/)
  • ⬜ Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nano

Partial log (click to expand)

shrinking /nix/store/l0m9vc7pkpifgjymw5283lm7s97hhriz-nano-3.1/bin/nano
gzipping man pages under /nix/store/l0m9vc7pkpifgjymw5283lm7s97hhriz-nano-3.1/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l0m9vc7pkpifgjymw5283lm7s97hhriz-nano-3.1/bin
patching script interpreter paths in /nix/store/l0m9vc7pkpifgjymw5283lm7s97hhriz-nano-3.1
checking for references to /build in /nix/store/l0m9vc7pkpifgjymw5283lm7s97hhriz-nano-3.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/9a1k94s5i81a0554pmix8n27h1wxqj95-nano-3.1-info
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9a1k94s5i81a0554pmix8n27h1wxqj95-nano-3.1-info
checking for references to /build in /nix/store/9a1k94s5i81a0554pmix8n27h1wxqj95-nano-3.1-info...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nano

Partial log (click to expand)

make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-nano-3.1.drv-0/nano-3.1'
make[1]: Leaving directory '/private/tmp/nix-build-nano-3.1.drv-0/nano-3.1'
post-installation fixup
gzipping man pages under /nix/store/db0sg2f11cczqlhrmflr34kyzlik65p6-nano-3.1/share/man/
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/db0sg2f11cczqlhrmflr34kyzlik65p6-nano-3.1/bin
patching script interpreter paths in /nix/store/db0sg2f11cczqlhrmflr34kyzlik65p6-nano-3.1
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/ncqx7l396yy8r787xj1aqfqlrwjn0cv2-nano-3.1-info

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nano

Partial log (click to expand)

shrinking /nix/store/7fh0m5rvq309z855b6c2kcibb4ch2gh1-nano-3.1/bin/nano
gzipping man pages under /nix/store/7fh0m5rvq309z855b6c2kcibb4ch2gh1-nano-3.1/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7fh0m5rvq309z855b6c2kcibb4ch2gh1-nano-3.1/bin
patching script interpreter paths in /nix/store/7fh0m5rvq309z855b6c2kcibb4ch2gh1-nano-3.1
checking for references to /build in /nix/store/7fh0m5rvq309z855b6c2kcibb4ch2gh1-nano-3.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/hvypwpbqv4d8a6pr1jficsn596m76nab-nano-3.1-info
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/hvypwpbqv4d8a6pr1jficsn596m76nab-nano-3.1-info
checking for references to /build in /nix/store/hvypwpbqv4d8a6pr1jficsn596m76nab-nano-3.1-info...

@srhb srhb merged commit 1c2d575 into NixOS:master Oct 7, 2018
srhb pushed a commit that referenced this pull request Oct 7, 2018
@samueldr @srhb
nano: 3.0 -> 3.1
be47bab 
(cherry picked from commit 65eb3e3)
Backport of #47991
@samueldr samueldr deleted the update/nano-3.1 branch February 12, 2019 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samueldr @GrahamcOfBorg @srhb