Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fastpbkdf2: init at 0.2 #47988

Merged
merged 1 commit into from Nov 3, 2018
Merged

pythonPackages.fastpbkdf2: init at 0.2 #47988

merged 1 commit into from Nov 3, 2018

Conversation

jqueiroz
Copy link
Member

@jqueiroz jqueiroz commented Oct 6, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jqueiroz jqueiroz requested a review from FRidh as a code owner October 6, 2018 23:02
@FRidh
Copy link
Member

FRidh commented Oct 13, 2018

@GrahamcOfBorg build pythonPackages.fastpbkdf2

@FRidh
Copy link
Member

FRidh commented Oct 13, 2018

@GrahamcOfBorg build python3Packages.fastpbkdf2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.fastpbkdf2

Partial log (click to expand)

============================= test session starts ==============================
platform linux2 -- Python 2.7.15, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/source, inifile:
collected 7 items

tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 2.01 seconds ===========================
pytestcachePhase
/nix/store/rrsm8i5pl3q6jcss9yclwd1qy828yakn-python2.7-fastpbkdf2-0.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.fastpbkdf2

Partial log (click to expand)

============================= test session starts ==============================
platform darwin -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /private/tmp/nix-build-python3.6-fastpbkdf2-0.2.drv-0/source, inifile:
collected 7 items

tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 2.67 seconds ===========================
pytestcachePhase
/nix/store/azkz5fnxw5qzajj5w9zf4q4d6xhz0268-python3.6-fastpbkdf2-0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.fastpbkdf2

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/source, inifile:
collected 7 items

tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 2.01 seconds ===========================
pytestcachePhase
/nix/store/xcq062vq7dj646cki4rh5cp3bb07c0jn-python3.6-fastpbkdf2-0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.fastpbkdf2

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/source, inifile:
collected 7 items

tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 3.53 seconds ===========================
pytestcachePhase
/nix/store/a2lima411nyznh7hwhgx8v39vpjpsc4j-python3.6-fastpbkdf2-0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.fastpbkdf2

Partial log (click to expand)

============================= test session starts ==============================
platform linux2 -- Python 2.7.15, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/source, inifile:
collected 7 items

tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 8.46 seconds ===========================
pytestcachePhase
/nix/store/z54vdchpgwm7gk5i26wvaq0yg6h2cl67-python2.7-fastpbkdf2-0.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.fastpbkdf2

Partial log (click to expand)

============================= test session starts ==============================
platform darwin -- Python 2.7.15, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /private/tmp/nix-build-python2.7-fastpbkdf2-0.2.drv-0/source, inifile:
collected 7 items

tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 3.36 seconds ===========================
pytestcachePhase
/nix/store/dsy57i1mvfyc1b3v0h7rn8vlasqixwnf-python2.7-fastpbkdf2-0.2

dotlambda
dotlambda requested changes Oct 30, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the usual blank lines to the expression.

pkgs/development/python-modules/fastpbkdf2/default.nix Show resolved Hide resolved
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.fastpbkdf2 python3.pkgs.fastpbkdf2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.fastpbkdf2, python3.pkgs.fastpbkdf2

Partial log (click to expand)

tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 2.78 seconds ===========================
pytestcachePhase
tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 2.75 seconds ===========================
pytestcachePhase
/nix/store/1xj3q22jq6rh5jdfmz73c50agn4hhg53-python2.7-fastpbkdf2-0.2
/nix/store/904x72szl9f83pli8qpa08b5zcgw2z7f-python3.6-fastpbkdf2-0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.fastpbkdf2, python3.pkgs.fastpbkdf2

Partial log (click to expand)

tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 2.01 seconds ===========================
pytestcachePhase
tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 2.01 seconds ===========================
pytestcachePhase
/nix/store/8rrnp1crpv52d3gpxzl7f7qlziraryh8-python2.7-fastpbkdf2-0.2
/nix/store/7rgvbzaqx4c8kd1f692sami9z16fnmcb-python3.6-fastpbkdf2-0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.fastpbkdf2, python3.pkgs.fastpbkdf2

Partial log (click to expand)

platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/source, inifile:
collected 7 items

tests/test_fastpbkdf2.py .......                                         [100%]

=========================== 7 passed in 3.53 seconds ===========================
pytestcachePhase
/nix/store/mqwdvxc94sp1kw8f10lx2fai3x0gccwl-python2.7-fastpbkdf2-0.2
/nix/store/c5gqx7812nshqcdniaazxy60qm35p5gn-python3.6-fastpbkdf2-0.2

@dotlambda dotlambda merged commit 4b095c6 into NixOS:master Nov 3, 2018
@jqueiroz jqueiroz deleted the python-fastpbkdf2 branch November 3, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jqueiroz @FRidh @GrahamcOfBorg @dotlambda