Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 2f1e44859d38
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 683c413118c1
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 6, 2018

  1. nixos/bash: Use escapeShellArg for shell aliases 

    This patch uses the library function `lib.escapeShellArg` to improve
the handling of shell aliases in the NixOS module `bash`, copying the
corresponding change made to the `zsh` module in commit
1e211a7 (for which GitHub pull
request #47471 was filed).

This patch resolves GitHub issue #16973.

This change presumably also should be copied to the `fish` module, but
I don't know `fish` syntax so that won't be done by me.

GitHub: Close #16973.
    @8573
    8573 committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    d8bcd2c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #47984 from 8573/8573/fix/Bash/use-escapeShellArg/1 

    nixos/bash: Use `escapeShellArg` for shell aliases
    @timokau
    timokau committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    683c413 View commit details
    Browse the repository at this point in the history