Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redmine: add selectable plugin support at the cost of reproducibility. (FYI only, NOT for merging) #48012

Closed
wants to merge 1 commit into from

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Oct 7, 2018

Motivation for this change

Installing Redmine with plugins. However I don't think it's reasonably doable to let the users select the wanted plugins and still ensuring reproducibility by fixing a gemset.nix, that would amount to roughly 2^|plugins| gemset.nix files.
I'm just sharing this attempt as an experiment that should not be merged, but might inspire others who know Nix better than I do. In the end, I myself am not sure to need Redmine, and the configuration of the main plugin I wanted is too difficult: I was unable to understand why redmine_git_hosting was sometimes issuing a working SSH connection to the gitolite user, and sometimes not (acting like there were a need to accept the server's key by having its connection postponed by sshd). So I'll stick to simple Gitolite and maybe Discourse. Anyway, hope this helps.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Thanks :) I'll close this though, no need to keep open a PR that isn't intended to be merged

@infinisil infinisil closed this Mar 30, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/packaging-a-redmine-plugin/15061/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants