Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

midisheetmusic: init at 2.6 #47978

Merged
merged 1 commit into from Oct 8, 2018
Merged

midisheetmusic: init at 2.6 #47978

merged 1 commit into from Oct 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2018

Motivation for this change

With this I've got better results converting MIDI to sheet than with rosegarden or musescore, it's also just one button to process. Though I've only tried simple melodies so far

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

joachifm commented Oct 8, 2018

@GrahamcOfBorg build midisheetmusic

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: midisheetmusic

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: midisheetmusic

Partial log (click to expand)

glibPreInstallPhase
installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/08bg8zghf2pxvnl49wkc2qvrjg9408pj-midisheetmusic
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/08bg8zghf2pxvnl49wkc2qvrjg9408pj-midisheetmusic/bin
patching script interpreter paths in /nix/store/08bg8zghf2pxvnl49wkc2qvrjg9408pj-midisheetmusic
checking for references to /build in /nix/store/08bg8zghf2pxvnl49wkc2qvrjg9408pj-midisheetmusic...
/nix/store/08bg8zghf2pxvnl49wkc2qvrjg9408pj-midisheetmusic

@joachifm joachifm merged commit 213fab6 into NixOS:master Oct 8, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: midisheetmusic

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@ghost
Copy link
Author

ghost commented Oct 9, 2018

@joachifm Thanks!

@ghost ghost deleted the midisheetmusic branch October 9, 2018 04:48
joachifm
joachifm reviewed Oct 9, 2018
View reviewed changes
pkgs/applications/audio/midisheetmusic/default.nix
let
version = "2.6";
in stdenv.mkDerivation {
name = "midisheetmusic";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, I just noticed version is not part of name, that should be fixed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joachifm Thanks! #48109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joachifm @GrahamcOfBorg