uhub: re-enable sqlite plugin / fix aarch64 build #48021

makefu · 2018-10-07T21:29:12Z

Motivation for this change

This PR re-enables the sqlite authentication plugin for uhub. It was disabled because of a failed build, but this seems to have been solved.
Additionally it fixes the build of uhub for aarch64

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-10-07T21:43:36Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: uhub

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-07T21:43:45Z

Failure on aarch64-linux (full log)

Attempted: uhub

Partial log (click to expand)

                 from /build/uhub-0.5.0/src/uhub.h:28,
                 from /build/uhub-0.5.0/autotest/test_commands.tcc:1,
                 from /build/uhub-0.5.0/autotest/test.c:47:
/nix/store/sfn26s5v25ij5dpm25wai61kzn1qib3d-glibc-2.27-dev/include/string.h:136:12: note: in a call to function 'strcmp' declared here
 extern int strcmp (const char *__s1, const char *__s2)
            ^~~~~~
make[1]: *** [CMakeFiles/Makefile2:224: CMakeFiles/test.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/3qg30r1n0spprdvipnm8si0grd7v2wca-uhub-0.5.0.drv' failed with exit code 2
error: build of '/nix/store/3qg30r1n0spprdvipnm8si0grd7v2wca-uhub-0.5.0.drv' failed

GrahamcOfBorg · 2018-10-07T21:44:04Z

Success on x86_64-linux (full log)

Attempted: uhub

Partial log (click to expand)

shrinking /nix/store/w4y05bzmwpdrjjsc7dlqhc916c5ldrpc-uhub-0.5.0-mod_topic/mod_topic.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/w4y05bzmwpdrjjsc7dlqhc916c5ldrpc-uhub-0.5.0-mod_topic
checking for references to /build in /nix/store/w4y05bzmwpdrjjsc7dlqhc916c5ldrpc-uhub-0.5.0-mod_topic...
shrinking RPATHs of ELF executables and libraries in /nix/store/phvic0adhjsl51yda6a1hhhd6i1xbayr-uhub-0.5.0-mod_no_guest_downloads
shrinking /nix/store/phvic0adhjsl51yda6a1hhhd6i1xbayr-uhub-0.5.0-mod_no_guest_downloads/mod_no_guest_downloads.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/phvic0adhjsl51yda6a1hhhd6i1xbayr-uhub-0.5.0-mod_no_guest_downloads
checking for references to /build in /nix/store/phvic0adhjsl51yda6a1hhhd6i1xbayr-uhub-0.5.0-mod_no_guest_downloads...
/nix/store/fg4bqcdl6s7dbn4mq7wsz6fd1bz5prj3-uhub-0.5.0

the project changed the code repository to github

makefu · 2018-10-07T23:00:41Z

@GrahamcOfBorg build uhub

GrahamcOfBorg · 2018-10-07T23:00:52Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: uhub

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-07T23:01:05Z

Success on x86_64-linux (full log)

Attempted: uhub

Partial log (click to expand)

shrinking /nix/store/3xcrcyjcqv5xlx2539jnir7mlv14n2rp-uhub-0.5.0-mod_topic/mod_topic.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3xcrcyjcqv5xlx2539jnir7mlv14n2rp-uhub-0.5.0-mod_topic
checking for references to /build in /nix/store/3xcrcyjcqv5xlx2539jnir7mlv14n2rp-uhub-0.5.0-mod_topic...
shrinking RPATHs of ELF executables and libraries in /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads
shrinking /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads/mod_no_guest_downloads.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads
checking for references to /build in /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads...
/nix/store/074jxpwvkf7av0ci30063hqkdsvc59z5-uhub-0.5.0

GrahamcOfBorg · 2018-10-07T23:01:13Z

Success on aarch64-linux (full log)

Attempted: uhub

Partial log (click to expand)

shrinking /nix/store/b0b860rlpiaiq6y9bivzr1k5g4sk77fs-uhub-0.5.0-mod_topic/mod_topic.so
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/b0b860rlpiaiq6y9bivzr1k5g4sk77fs-uhub-0.5.0-mod_topic
checking for references to /build in /nix/store/b0b860rlpiaiq6y9bivzr1k5g4sk77fs-uhub-0.5.0-mod_topic...
shrinking RPATHs of ELF executables and libraries in /nix/store/2bbwvwphcj89pg1a7m0xjc2xk14hyf7m-uhub-0.5.0-mod_no_guest_downloads
shrinking /nix/store/2bbwvwphcj89pg1a7m0xjc2xk14hyf7m-uhub-0.5.0-mod_no_guest_downloads/mod_no_guest_downloads.so
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2bbwvwphcj89pg1a7m0xjc2xk14hyf7m-uhub-0.5.0-mod_no_guest_downloads
checking for references to /build in /nix/store/2bbwvwphcj89pg1a7m0xjc2xk14hyf7m-uhub-0.5.0-mod_no_guest_downloads...
/nix/store/8dv3dsidm7i3sc2zazqd5hf456m9463b-uhub-0.5.0

GrahamcOfBorg · 2018-10-07T23:11:35Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: uhub

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-07T23:11:40Z

Success on aarch64-linux (full log)

Attempted: uhub

Partial log (click to expand)

/nix/store/8dv3dsidm7i3sc2zazqd5hf456m9463b-uhub-0.5.0

GrahamcOfBorg · 2018-10-07T23:11:46Z

Success on x86_64-linux (full log)

Attempted: uhub

Partial log (click to expand)

shrinking /nix/store/3xcrcyjcqv5xlx2539jnir7mlv14n2rp-uhub-0.5.0-mod_topic/mod_topic.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3xcrcyjcqv5xlx2539jnir7mlv14n2rp-uhub-0.5.0-mod_topic
checking for references to /build in /nix/store/3xcrcyjcqv5xlx2539jnir7mlv14n2rp-uhub-0.5.0-mod_topic...
shrinking RPATHs of ELF executables and libraries in /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads
shrinking /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads/mod_no_guest_downloads.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads
checking for references to /build in /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads...
/nix/store/074jxpwvkf7av0ci30063hqkdsvc59z5-uhub-0.5.0

Ekleog · 2018-10-11T14:50:55Z

@makefu Any reference to an upstream issue where the patch you're adding is discussed? This would be helpful to be able to eventually remove it, I think :)

makefu · 2018-10-11T16:00:31Z

@Ekleog i've added a reference to the debian bug (open since 2014)

GrahamcOfBorg · 2018-10-11T16:12:31Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: uhub

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-11T16:12:43Z

Success on aarch64-linux (full log)

Attempted: uhub

Partial log (click to expand)

shrinking /nix/store/b0b860rlpiaiq6y9bivzr1k5g4sk77fs-uhub-0.5.0-mod_topic/mod_topic.so
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/b0b860rlpiaiq6y9bivzr1k5g4sk77fs-uhub-0.5.0-mod_topic
checking for references to /build in /nix/store/b0b860rlpiaiq6y9bivzr1k5g4sk77fs-uhub-0.5.0-mod_topic...
shrinking RPATHs of ELF executables and libraries in /nix/store/2bbwvwphcj89pg1a7m0xjc2xk14hyf7m-uhub-0.5.0-mod_no_guest_downloads
shrinking /nix/store/2bbwvwphcj89pg1a7m0xjc2xk14hyf7m-uhub-0.5.0-mod_no_guest_downloads/mod_no_guest_downloads.so
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2bbwvwphcj89pg1a7m0xjc2xk14hyf7m-uhub-0.5.0-mod_no_guest_downloads
checking for references to /build in /nix/store/2bbwvwphcj89pg1a7m0xjc2xk14hyf7m-uhub-0.5.0-mod_no_guest_downloads...
/nix/store/8dv3dsidm7i3sc2zazqd5hf456m9463b-uhub-0.5.0

GrahamcOfBorg · 2018-10-11T16:13:57Z

Success on x86_64-linux (full log)

Attempted: uhub

Partial log (click to expand)

shrinking /nix/store/3xcrcyjcqv5xlx2539jnir7mlv14n2rp-uhub-0.5.0-mod_topic/mod_topic.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3xcrcyjcqv5xlx2539jnir7mlv14n2rp-uhub-0.5.0-mod_topic
checking for references to /build in /nix/store/3xcrcyjcqv5xlx2539jnir7mlv14n2rp-uhub-0.5.0-mod_topic...
shrinking RPATHs of ELF executables and libraries in /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads
shrinking /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads/mod_no_guest_downloads.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads
checking for references to /build in /nix/store/flz6hm05p7h8f9r7vvgq5jy1nssyzhs7-uhub-0.5.0-mod_no_guest_downloads...
/nix/store/074jxpwvkf7av0ci30063hqkdsvc59z5-uhub-0.5.0

Ekleog · 2018-10-11T17:01:11Z

I've just opened janvidar/uhub#46 upstream based on the bug you linked (maybe the author never saw the debian bug), you may want to link to it instead? :)

makefu · 2018-10-11T20:36:47Z

i've removed the patch file and instead pull it from the github PR i've opened

GrahamcOfBorg · 2018-10-11T20:55:13Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: uhub

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-11T20:55:24Z

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: uhub

Partial log (click to expand)

building '/nix/store/hi6r9xcxs597ch0f2kijr719xn11q3iv-47.patch.drv'...

trying https://github.com/janvidar/uhub/pull/47.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138    0   138    0     0    958      0 --:--:-- --:--:-- --:--:--   951
100   735    0   735    0     0   1444      0 --:--:-- --:--:-- --:--:--  1444
fixed-output derivation produced path '/nix/store/c9gmgrvasy3c6fynsqdsx82q28b1a0vb-47.patch' with sha256 hash '07yik6za89ar5bxm7m2183i7f6hfbawbxvd4vs02n1zr2fgfxmiq' instead of the expected hash '0dwyas1b183dgyrp002im6qkxfhsfwscj25z7lrmawrq6xxxwxi4'
cannot build derivation '/nix/store/wcflny6d91adf8rybmad8a2h5vp5yp9w-uhub-0.5.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/wcflny6d91adf8rybmad8a2h5vp5yp9w-uhub-0.5.0.drv' failed

GrahamcOfBorg · 2018-10-11T20:56:03Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: uhub

Partial log (click to expand)

building '/nix/store/m307n826lg8k6366dcw8c1xy3hnjpwl3-47.patch.drv'...

trying https://github.com/janvidar/uhub/pull/47.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138    0   138    0     0   1301      0 --:--:-- --:--:-- --:--:--  1314
100   735    0   735    0     0   2161      0 --:--:-- --:--:-- --:--:--  2161
fixed-output derivation produced path '/nix/store/c9gmgrvasy3c6fynsqdsx82q28b1a0vb-47.patch' with sha256 hash '07yik6za89ar5bxm7m2183i7f6hfbawbxvd4vs02n1zr2fgfxmiq' instead of the expected hash '0dwyas1b183dgyrp002im6qkxfhsfwscj25z7lrmawrq6xxxwxi4'
cannot build derivation '/nix/store/hclc7syc7hfjygxl4hxyiw15295jj6y3-uhub-0.5.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/hclc7syc7hfjygxl4hxyiw15295jj6y3-uhub-0.5.0.drv' failed

Ekleog · 2018-10-12T02:35:50Z

@makefu Looks like a problem with the patch hash now :/ (don't know if you read ofborg's emails)

makefu · 2018-10-12T11:42:53Z

@Ekleog weird thing, let me try again. I do not receive ofborg mails for some reason, is there any button where i can enable it?

related: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770175 related: janvidar/uhub#46

GrahamcOfBorg · 2018-10-12T11:59:14Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: uhub

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-12T11:59:22Z

Success on x86_64-linux (full log)

Attempted: uhub

Partial log (click to expand)

shrinking /nix/store/nn8mjdmc3xyvwq7hw1qqs91p7yz8na7h-uhub-0.5.0-mod_topic/mod_topic.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/nn8mjdmc3xyvwq7hw1qqs91p7yz8na7h-uhub-0.5.0-mod_topic
checking for references to /build in /nix/store/nn8mjdmc3xyvwq7hw1qqs91p7yz8na7h-uhub-0.5.0-mod_topic...
shrinking RPATHs of ELF executables and libraries in /nix/store/866zhxlpkx6gbarknlxa8ci8b9i16gy5-uhub-0.5.0-mod_no_guest_downloads
shrinking /nix/store/866zhxlpkx6gbarknlxa8ci8b9i16gy5-uhub-0.5.0-mod_no_guest_downloads/mod_no_guest_downloads.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/866zhxlpkx6gbarknlxa8ci8b9i16gy5-uhub-0.5.0-mod_no_guest_downloads
checking for references to /build in /nix/store/866zhxlpkx6gbarknlxa8ci8b9i16gy5-uhub-0.5.0-mod_no_guest_downloads...
/nix/store/5zxd31rx0rv6rnx3bhdm0zdcrh56a01b-uhub-0.5.0

GrahamcOfBorg · 2018-10-12T11:59:23Z

Success on aarch64-linux (full log)

Attempted: uhub

Partial log (click to expand)

shrinking /nix/store/v6fqhh79pr44rizcb6dyqw2dn88351cc-uhub-0.5.0-mod_topic/mod_topic.so
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/v6fqhh79pr44rizcb6dyqw2dn88351cc-uhub-0.5.0-mod_topic
checking for references to /build in /nix/store/v6fqhh79pr44rizcb6dyqw2dn88351cc-uhub-0.5.0-mod_topic...
shrinking RPATHs of ELF executables and libraries in /nix/store/ayihfs1v30gpzjb93qpqpyb8zjn41rjz-uhub-0.5.0-mod_no_guest_downloads
shrinking /nix/store/ayihfs1v30gpzjb93qpqpyb8zjn41rjz-uhub-0.5.0-mod_no_guest_downloads/mod_no_guest_downloads.so
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ayihfs1v30gpzjb93qpqpyb8zjn41rjz-uhub-0.5.0-mod_no_guest_downloads
checking for references to /build in /nix/store/ayihfs1v30gpzjb93qpqpyb8zjn41rjz-uhub-0.5.0-mod_no_guest_downloads...
/nix/store/gmh8q7gzz29lbib25jdsbwy7179gyhx0-uhub-0.5.0

Ekleog · 2018-10-12T13:52:56Z

@makefu I don't know, sorry, it's sent through the same mechanism as all github comments theoretically :/ maybe in your spam folder?

Anyway, I think that's ready to be merged, thanks! :)

makefu · 2018-10-12T19:50:46Z

ah you mean these mails :D yes, i get them but i was busy doing daily work

makefu · 2018-10-17T13:19:15Z

anything holding this PR to be merged?

uhub: re-enable sqlite plugin

f81fe9d

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Oct 7, 2018

uhub: use official upstream sources

92a77c3

the project changed the code repository to github

makefu changed the title ~~uhub: re-enable sqlite plugin~~ uhub: re-enable sqlite plugin / fix aarch64 build Oct 7, 2018

makefu force-pushed the pkgs/uhub/enable-mod-auth-sqlite branch from 5034d21 to ae83f87 Compare October 11, 2018 15:59

Ekleog mentioned this pull request Oct 11, 2018

Fix build on AArch64 janvidar/uhub#46

Closed

makefu force-pushed the pkgs/uhub/enable-mod-auth-sqlite branch from ae83f87 to 7e861a8 Compare October 11, 2018 20:35

uhub: fix build for aarch64

d74ea28

related: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770175 related: janvidar/uhub#46

makefu force-pushed the pkgs/uhub/enable-mod-auth-sqlite branch from 7e861a8 to d74ea28 Compare October 12, 2018 11:44

infinisil merged commit 4473d3d into NixOS:master Oct 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

uhub: re-enable sqlite plugin / fix aarch64 build #48021

uhub: re-enable sqlite plugin / fix aarch64 build #48021

makefu commented Oct 7, 2018 •

edited

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

makefu commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

Ekleog commented Oct 11, 2018

makefu commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

Ekleog commented Oct 11, 2018

makefu commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

Ekleog commented Oct 12, 2018

makefu commented Oct 12, 2018 •

edited

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

Ekleog commented Oct 12, 2018 •

edited

makefu commented Oct 12, 2018

makefu commented Oct 17, 2018

uhub: re-enable sqlite plugin / fix aarch64 build #48021

uhub: re-enable sqlite plugin / fix aarch64 build #48021

Conversation

makefu commented Oct 7, 2018 • edited

Motivation for this change

Things done

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

makefu commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

GrahamcOfBorg commented Oct 7, 2018

Ekleog commented Oct 11, 2018

makefu commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

Ekleog commented Oct 11, 2018

makefu commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

GrahamcOfBorg commented Oct 11, 2018

Ekleog commented Oct 12, 2018

makefu commented Oct 12, 2018 • edited

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

Ekleog commented Oct 12, 2018 • edited

makefu commented Oct 12, 2018

makefu commented Oct 17, 2018

makefu commented Oct 7, 2018 •

edited

makefu commented Oct 12, 2018 •

edited

Ekleog commented Oct 12, 2018 •

edited