Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade FreeCAD to qt5, maybe fix seg fault #47992

Closed
wants to merge 1 commit into from
Closed

Upgrade FreeCAD to qt5, maybe fix seg fault #47992

wants to merge 1 commit into from

Conversation

waynr
Copy link
Contributor

@waynr waynr commented Oct 7, 2018

See #42790

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

Instead of passing in qt5, use libsForQt5.callPackage instead as it sets up the environment for a qt5 build.

@peterhoeg
Copy link
Member

There is a lot more work required to get this compiling on qt5, just FYI.

@waynr
Copy link
Contributor Author

waynr commented Oct 7, 2018

Yeah I was just looking at the upstream bug tracker: https://www.freecadweb.org/tracker/view.php?id=2986

Not sure how much time I can sink into this right now :(

@luzpaz
Copy link
Contributor

luzpaz commented Jan 8, 2019

It's not there just yet but there is a pending upstream 0.18 release. Qt5 will be default for it. When the time comes then we can cross FreeCAD off of #33248

@luzpaz luzpaz mentioned this pull request Jan 8, 2019
Closed
@gebner
Copy link
Member

gebner commented Jun 19, 2019

Fixed in #63348.

@gebner gebner closed this Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@waynr @peterhoeg @luzpaz @gebner @GrahamcOfBorg