Fix NetworkManager patches with fetchpatch and updated hashes #48023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Had someone on IRC who couldn't
nixos-rebuild
because the second patch here had changed hashes. Looks like there's some irrelevant version number gitlab is appending to the patch file. Usingfetchpatch
should prevent this from being an issue in the future if I understand correctly.Sidenote, while I was testing this out, I found I could download the results of the old expression from https://cache.nixos.org by running
nix-build -A networkmanager.patches
. (EDIT: IRC user couldn't because they hadsubstituters = http://nixos-arm.dezgeg.me/channel
). However it's been pointed out to me thatfetchurl
is supposed to enablepreferLocalBuild
, which is supposed to prevent this. Is this a bug in Nix?Sidenote 2, is there a particular reason this derivation doesn't have
enableParallelBuilding = true
? It's quite a slow build without that, for my 32 thread machine :PThings done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)