Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport tor-browser-bundle-bin minor update #48014

Merged
merged 1 commit into from Oct 7, 2018
Merged

backport tor-browser-bundle-bin minor update #48014

merged 1 commit into from Oct 7, 2018

Conversation

schmittlauch
Copy link
Member

@schmittlauch schmittlauch commented Oct 7, 2018 •
edited

tor-browser-bundle-bin: 8.0.1 -> 8.0.2

Update to latest version due to security updates and 8.0.1 not being
available on the mirrors anymore.

Release notes: https://blog.torproject.org/new-release-tor-browser-802

(cherry picked from commit 248ed35)

Motivation for this change

reason: The binary dist-file of tor-browser-bundle-bin-8.0.2 is gone
from the mirrors, making the derivation for v8.0.1 fail.
This is just a minor version bump.

Things done

cherry-picked version-bump commit from master

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir @schmittlauch
backport tor-browser-bundle-bin minor update
34eb9f7 
tor-browser-bundle-bin: 8.0.1 -> 8.0.2

Update to latest version due to security updates and 8.0.1 not being
available on the mirrors anymore.

Release notes: https://blog.torproject.org/new-release-tor-browser-802

(cherry picked from commit 248ed35)

reason: The binary dist-file of tor-browser-bundle-bin-8.0.2 is gone
from the mirrors, making the derivation for v8.0.1 fail.
This is just a minor version bump.
@makefu
Copy link
Contributor

makefu commented Oct 7, 2018

@GrahamcOfBorg build torbrowser

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: torbrowser

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: torbrowser

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: torbrowser

Partial log (click to expand)

copying path '/nix/store/y1g7cvczk10q6bg9144xjrp9wkrn3l14-gtk+3-3.22.30' from 'https://cache.nixos.org'...
building '/nix/store/grwz6d9cajx1km0wjn8n08h0wmqf3ivd-tor-browser-bundle-bin-8.0.2.drv'...
/nix/store/s73gcfjglmq3zq0hbciwd6pnb9y788x6-tor-browser-bundle-bin-8.0.2/share/tor-browser /build
Setting ELF interpreter on firefox.real ...
warning: working around a Linux kernel bug by creating a hole of 4096 bytes in ‘firefox.real’
Setting ELF interpreter on TorBrowser/Tor/tor ...
warning: working around a Linux kernel bug by creating a hole of 2113536 bytes in ‘TorBrowser/Tor/tor’
Checking bundled Tor ...
Checking tor-browser wrapper ...
/nix/store/s73gcfjglmq3zq0hbciwd6pnb9y788x6-tor-browser-bundle-bin-8.0.2

@makefu
Copy link
Contributor

makefu commented Oct 7, 2018

lgtm

@andir andir merged commit 76e4d16 into NixOS:release-18.09 Oct 7, 2018
@schmittlauch schmittlauch deleted the backport-tbb-bin-8.0.2 branch October 7, 2018 18:12
@Mic92
Copy link
Member

Mic92 commented Oct 8, 2018

@andir do we want this in 18.03 as well?

@andir
Copy link
Member

andir commented Oct 8, 2018 via email

@Mic92
Copy link
Member

Mic92 commented Oct 8, 2018

#48063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@schmittlauch @makefu @GrahamcOfBorg @Mic92 @andir @Janik-Haag