Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slic3r-prusa3d: 1.40.1 -> 1.41.0 #47983

Closed
wants to merge 1 commit into from
Closed

slic3r-prusa3d: 1.40.1 -> 1.41.0 #47983

wants to merge 1 commit into from

Conversation

thorstenweber83
Copy link
Contributor

Motivation for this change

update package

Things done
  • [ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ x ] Tested execution of all binary files (usually in ./result/bin/)
  • [ x ] Determined the impact on package closure size (by running nix path-info -S before and after)

before: 699469264
after: 701066728
~ 1.5MB increase

@Moredread
Copy link
Contributor

PR #44077 also addresses the package upgrade. It also has a few additional comments explaining the patches we apply. :)

@Moredread
Copy link
Contributor

Moredread commented Oct 6, 2018 •
edited

@thorstenweber should I CC you in the future when I post a PR for slic3r-prusa3d? I'm quite keen on keeping up with upstream.

@thorstenweber83
Copy link
Contributor Author

@Moredread yes, please! That would be nice! I finally had some time on my hands but hadn't thought of looking into pull requests first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thorstenweber83 @Moredread @GrahamcOfBorg