Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bash: Use escapeShellArg for shell aliases #47984

Merged
merged 1 commit into from Oct 6, 2018
Merged

nixos/bash: Use escapeShellArg for shell aliases #47984

merged 1 commit into from Oct 6, 2018

Conversation

8573
Copy link
Contributor

@8573 8573 commented Oct 6, 2018

This patch uses the library function lib.escapeShellArg to improve the handling of shell aliases in the NixOS module bash, copying the corresponding change made to the zsh module in commit 1e211a7 (for which GitHub pull request #47471 was filed).

This patch resolves GitHub issue #16973.

This change presumably also should be copied to the fish module, but I don't know fish syntax so that won't be done by me.

Motivation for this change

See issue ticket #16973.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@8573
nixos/bash: Use escapeShellArg for shell aliases
d8bcd2c 
This patch uses the library function `lib.escapeShellArg` to improve
the handling of shell aliases in the NixOS module `bash`, copying the
corresponding change made to the `zsh` module in commit
1e211a7 (for which GitHub pull
request NixOS#47471 was filed).

This patch resolves GitHub issue NixOS#16973.

This change presumably also should be copied to the `fish` module, but
I don't know `fish` syntax so that won't be done by me.

GitHub: Close NixOS#16973.
@timokau
Copy link
Member

timokau commented Oct 6, 2018

Thanks for fixing that :)

@timokau timokau merged commit 683c413 into NixOS:master Oct 6, 2018
@timokau timokau mentioned this pull request Oct 6, 2018
Closed
@mnacamura mnacamura mentioned this pull request Oct 8, 2018
Merged
9 tasks
@trueNAHO trueNAHO mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@8573 @timokau @GrahamcOfBorg