Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonnet: skip building the website #47981

Merged
merged 1 commit into from Oct 8, 2018
Merged

jsonnet: skip building the website #47981

merged 1 commit into from Oct 8, 2018

Conversation

benley
Copy link
Member

@benley benley commented Oct 6, 2018

Motivation for this change

The emscripten build of jsonnet is only used in the interactive demo found on jsonnet.org, and I don't think we need to include the whole website in our package. This reduces the transitive closure from
~100mb to ~32mb, and the build duration from ~8 minutes to ~20 seconds on my machine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

followup from #47939

@benley
jsonnet: skip building the website
ddb3b3e 
The emscripten build of jsonnet is only used in the interactive demo
found on jsonnet.org, and I don't think we need to include the whole
website in our package.  This reduces the transitive closure from
~100mb to ~32mb, and the build duration from ~8 minutes to ~20 seconds
on my machine.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: jsonnet

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5ma17yf70kdan2kc3j8056gp81r4abmf-jsonnet-0.11.2
shrinking /nix/store/5ma17yf70kdan2kc3j8056gp81r4abmf-jsonnet-0.11.2/lib/libjsonnet.so
shrinking /nix/store/5ma17yf70kdan2kc3j8056gp81r4abmf-jsonnet-0.11.2/bin/jsonnet
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5ma17yf70kdan2kc3j8056gp81r4abmf-jsonnet-0.11.2/lib  /nix/store/5ma17yf70kdan2kc3j8056gp81r4abmf-jsonnet-0.11.2/bin
patching script interpreter paths in /nix/store/5ma17yf70kdan2kc3j8056gp81r4abmf-jsonnet-0.11.2
checking for references to /build in /nix/store/5ma17yf70kdan2kc3j8056gp81r4abmf-jsonnet-0.11.2...
/nix/store/5ma17yf70kdan2kc3j8056gp81r4abmf-jsonnet-0.11.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jsonnet

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3ncdpairh9cyxsvh8mhnbnvxgrpm3j11-jsonnet-0.11.2
shrinking /nix/store/3ncdpairh9cyxsvh8mhnbnvxgrpm3j11-jsonnet-0.11.2/bin/jsonnet
shrinking /nix/store/3ncdpairh9cyxsvh8mhnbnvxgrpm3j11-jsonnet-0.11.2/lib/libjsonnet.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3ncdpairh9cyxsvh8mhnbnvxgrpm3j11-jsonnet-0.11.2/lib  /nix/store/3ncdpairh9cyxsvh8mhnbnvxgrpm3j11-jsonnet-0.11.2/bin
patching script interpreter paths in /nix/store/3ncdpairh9cyxsvh8mhnbnvxgrpm3j11-jsonnet-0.11.2
checking for references to /build in /nix/store/3ncdpairh9cyxsvh8mhnbnvxgrpm3j11-jsonnet-0.11.2...
/nix/store/3ncdpairh9cyxsvh8mhnbnvxgrpm3j11-jsonnet-0.11.2

@benley benley merged commit 641cb61 into NixOS:master Oct 8, 2018
@benley benley deleted the jsonnet-closure branch October 8, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmahoney pmahoney pmahoney approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benley @GrahamcOfBorg @pmahoney