Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sslib: init at 0.2.0 #47985

Merged
merged 1 commit into from Nov 4, 2018
Merged

pythonPackages.sslib: init at 0.2.0 #47985

merged 1 commit into from Nov 4, 2018

Conversation

jqueiroz
Copy link
Member

@jqueiroz jqueiroz commented Oct 6, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jqueiroz jqueiroz requested a review from FRidh as a code owner October 6, 2018 21:09
@FRidh
Copy link
Member

FRidh commented Oct 13, 2018

@GrahamcOfBorg build pythonPackages.sslib python3Packages.sslib

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.sslib

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.sslib

Partial log (click to expand)

writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/7s2z64qbarip13ikzyqmncn73w74m8w2-python3.6-sslib-0.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.sslib

The following builds were skipped because they don't evaluate on x86_64-linux: pythonPackages.sslib

Partial log (click to expand)

writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/9whh2yh56cgd44cx61j8052m7qqrabxq-python3.6-sslib-0.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.sslib

The following builds were skipped because they don't evaluate on aarch64-linux: pythonPackages.sslib

Partial log (click to expand)

writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/25jdx7ijygrmfyk5cajdp2j8r3mdv13f-python3.6-sslib-0.2.0

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3Packages.sslib

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.sslib

Partial log (click to expand)

writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ly3qlizgvsw361szifaq2ckqjq8f7idp-python3.6-sslib-0.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.sslib

Partial log (click to expand)

writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/6q1wbc49rgzhz1clsyyabw19xys6arcm-python3.6-sslib-0.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.sslib

Partial log (click to expand)

writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/vx862jkr276vz5hb4p8cckd7rplwxfln-python3.6-sslib-0.2.0

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase or - if there are no tests - set doCheck = false and add a comment with the reason.

@jqueiroz
Copy link
Member Author

jqueiroz commented Nov 3, 2018

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase or - if there are no tests - set doCheck = false and add a comment with the reason.

Fixed, thanks.

@dotlambda dotlambda merged commit 05f368b into NixOS:master Nov 4, 2018
@jqueiroz jqueiroz deleted the sslib branch November 5, 2018 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@dotlambda dotlambda dotlambda requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jqueiroz @FRidh @GrahamcOfBorg @dotlambda