NDISWrapper #47998

dingxiangfei2009 · 2018-10-07T11:21:36Z

Motivation for this change

NDISWrapper was updated to support newer kernels, located at https://github.com/pigiri/ndiswrapper.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

infinisil · 2018-10-12T13:10:06Z

@GrahamcOfBorg build linuxPackages.ndiswrapper

GrahamcOfBorg · 2018-10-12T13:10:17Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.ndiswrapper

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14162:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14162:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14474:16, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14474:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:51:1

GrahamcOfBorg · 2018-10-12T13:10:38Z

Failure on aarch64-linux (full log)

Attempted: linuxPackages.ndiswrapper

Partial log (click to expand)

make[5]: *** [/nix/store/dlk4bsnhp12rkipcp13iiib6fkhls6v6-linux-4.14.75-dev/lib/modules/4.14.75/source/scripts/Makefile.build:329: /build/source/ndiswrapper/driver/crt.o] Error 1
make[4]: *** [/nix/store/dlk4bsnhp12rkipcp13iiib6fkhls6v6-linux-4.14.75-dev/lib/modules/4.14.75/source/Makefile:1527: _module_/build/source/ndiswrapper/driver] Error 2
make[3]: *** [Makefile:146: sub-make] Error 2
make[2]: *** [Makefile:24: __sub-make] Error 2
make[2]: Leaving directory '/nix/store/dlk4bsnhp12rkipcp13iiib6fkhls6v6-linux-4.14.75-dev/lib/modules/4.14.75/build'
make[1]: *** [Makefile:183: modules] Error 2
make[1]: Leaving directory '/build/source/ndiswrapper/driver'
make: *** [Makefile:23: driver] Error 2
builder for '/nix/store/vlfzbfjhswiqi1sfpbxq40bw1kwv8ynw-ndiswrapper-1.62-pre-4.14.75.drv' failed with exit code 2
error: build of '/nix/store/vlfzbfjhswiqi1sfpbxq40bw1kwv8ynw-ndiswrapper-1.62-pre-4.14.75.drv' failed

GrahamcOfBorg · 2018-10-12T13:11:34Z

Success on x86_64-linux (full log)

Attempted: linuxPackages.ndiswrapper

Partial log (click to expand)

wrong ELF type
shrinking /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/sbin/loadndisdriver
gzipping man pages under /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/lib  /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/sbin
patching script interpreter paths in /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75
checking for references to /build in /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75...
wrong ELF type
moving /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/sbin/* to /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/bin
/nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75

infinisil

Along with the platform thing, please squash all commits into a single one and change the commit message to linuxPackages.ndiswrapper: 1.59 -> 1.62-pre, fix build

pkgs/os-specific/linux/ndiswrapper/default.nix

dingxiangfei2009 · 2018-11-07T05:28:30Z

@infinisil How is it looking?

infinisil · 2018-11-07T21:50:40Z

@GrahamcOfBorg build linuxPackages.ndiswrapper

GrahamcOfBorg · 2018-11-07T21:50:56Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.ndiswrapper

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14315:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14315:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14613:16, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14613:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:51:1

GrahamcOfBorg · 2018-11-07T21:50:57Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: linuxPackages.ndiswrapper

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-11-07T21:51:09Z

Success on x86_64-linux (full log)

Attempted: linuxPackages.ndiswrapper

Partial log (click to expand)

shrinking /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/lib/modules/4.14.79/misc/ndiswrapper.ko
wrong ELF type
gzipping man pages under /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/lib  /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/sbin
patching script interpreter paths in /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79
checking for references to /build in /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79...
wrong ELF type
moving /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/sbin/* to /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/bin
/nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Oct 7, 2018

infinisil requested changes Oct 12, 2018

View reviewed changes

pkgs/os-specific/linux/ndiswrapper/default.nix Show resolved Hide resolved

linuxPackages.ndiswrapper: 1.59 -> 1.62-pre, fix build

d593c4d

dingxiangfei2009 force-pushed the ndiswrapper branch from e332df8 to d593c4d Compare October 29, 2018 08:06

GrahamcOfBorg added the 8.has: package (new) label Oct 29, 2018

infinisil approved these changes Nov 7, 2018

View reviewed changes

infinisil merged commit 2d38bc6 into NixOS:master Nov 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NDISWrapper #47998

NDISWrapper #47998

dingxiangfei2009 commented Oct 7, 2018 •

edited

infinisil commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

infinisil left a comment

dingxiangfei2009 commented Nov 7, 2018

infinisil commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

NDISWrapper #47998

NDISWrapper #47998

Conversation

dingxiangfei2009 commented Oct 7, 2018 • edited

Motivation for this change

Things done

infinisil commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

GrahamcOfBorg commented Oct 12, 2018

infinisil left a comment

Choose a reason for hiding this comment

dingxiangfei2009 commented Nov 7, 2018

infinisil commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

dingxiangfei2009 commented Oct 7, 2018 •

edited