Skip to content

NDISWrapper #47998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

NDISWrapper #47998

merged 1 commit into from
Nov 7, 2018
+22 −15

Conversation

dingxiangfei2009
Copy link
Contributor

@dingxiangfei2009 dingxiangfei2009 commented Oct 7, 2018 •
edited
Loading

Motivation for this change

NDISWrapper was updated to support newer kernels, located at https://github.com/pigiri/ndiswrapper.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Oct 7, 2018
@infinisil
Copy link
Member

@GrahamcOfBorg build linuxPackages.ndiswrapper

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.ndiswrapper

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14162:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14162:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14474:16, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14474:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:51:1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: linuxPackages.ndiswrapper

Partial log (click to expand)

make[5]: *** [/nix/store/dlk4bsnhp12rkipcp13iiib6fkhls6v6-linux-4.14.75-dev/lib/modules/4.14.75/source/scripts/Makefile.build:329: /build/source/ndiswrapper/driver/crt.o] Error 1
make[4]: *** [/nix/store/dlk4bsnhp12rkipcp13iiib6fkhls6v6-linux-4.14.75-dev/lib/modules/4.14.75/source/Makefile:1527: _module_/build/source/ndiswrapper/driver] Error 2
make[3]: *** [Makefile:146: sub-make] Error 2
make[2]: *** [Makefile:24: __sub-make] Error 2
make[2]: Leaving directory '/nix/store/dlk4bsnhp12rkipcp13iiib6fkhls6v6-linux-4.14.75-dev/lib/modules/4.14.75/build'
make[1]: *** [Makefile:183: modules] Error 2
make[1]: Leaving directory '/build/source/ndiswrapper/driver'
make: *** [Makefile:23: driver] Error 2
builder for '/nix/store/vlfzbfjhswiqi1sfpbxq40bw1kwv8ynw-ndiswrapper-1.62-pre-4.14.75.drv' failed with exit code 2
error: build of '/nix/store/vlfzbfjhswiqi1sfpbxq40bw1kwv8ynw-ndiswrapper-1.62-pre-4.14.75.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: linuxPackages.ndiswrapper

Partial log (click to expand)

wrong ELF type
shrinking /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/sbin/loadndisdriver
gzipping man pages under /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/lib  /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/sbin
patching script interpreter paths in /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75
checking for references to /build in /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75...
wrong ELF type
moving /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/sbin/* to /nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75/bin
/nix/store/h57fi8985lgk3kwlznmfh6r9vq6f48gv-ndiswrapper-1.62-pre-4.14.75

infinisil
infinisil requested changes Oct 12, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with the platform thing, please squash all commits into a single one and change the commit message to linuxPackages.ndiswrapper: 1.59 -> 1.62-pre, fix build

@dingxiangfei2009
linuxPackages.ndiswrapper: 1.59 -> 1.62-pre, fix build

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 43C9E53FFCF51DEC
Verified
Learn about vigilant mode
d593c4d
@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Oct 29, 2018
@dingxiangfei2009
Copy link
Contributor Author

@infinisil How is it looking?

@infinisil
Copy link
Member

@GrahamcOfBorg build linuxPackages.ndiswrapper

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.ndiswrapper

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14315:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14315:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14613:16, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14613:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:51:1

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: linuxPackages.ndiswrapper

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: linuxPackages.ndiswrapper

Partial log (click to expand)

shrinking /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/lib/modules/4.14.79/misc/ndiswrapper.ko
wrong ELF type
gzipping man pages under /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/lib  /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/sbin
patching script interpreter paths in /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79
checking for references to /build in /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79...
wrong ELF type
moving /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/sbin/* to /nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79/bin
/nix/store/jgdbj29bv03911wg9qv9jj1v7gs27qmf-ndiswrapper-1.62-pre-4.14.79

@infinisil infinisil merged commit 2d38bc6 into NixOS:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dingxiangfei2009 @infinisil @GrahamcOfBorg