Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nload output corrupting a few seconds after starting #48017

Merged
merged 1 commit into from Oct 11, 2018
Merged

Fix nload output corrupting a few seconds after starting #48017

merged 1 commit into from Oct 11, 2018

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Oct 7, 2018 •
edited

See rolandriegel/nload#3

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

I'll let CI test the build for me (since I use this in an overlay).

I have tested the effectiveness of the patch itself on NixOS.

@nh2 nh2 changed the title nload output corrupts a few seconds after starting. Fix nload output corrupting a few seconds after starting Oct 7, 2018
@nh2
nload: Include patch to fix screen corruption.
ece7ece 
See added comment for details.
@xeji
Copy link
Contributor

xeji commented Oct 11, 2018

@GrahamcOfBorg build nload

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: nload

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nload

Partial log (click to expand)

make[1]: Leaving directory '/build/nload-0.7.4'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wj98jglp5z4pdjh6dzhfscl80i7ify8d-nload-0.7.4
shrinking /nix/store/wj98jglp5z4pdjh6dzhfscl80i7ify8d-nload-0.7.4/bin/nload
gzipping man pages under /nix/store/wj98jglp5z4pdjh6dzhfscl80i7ify8d-nload-0.7.4/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wj98jglp5z4pdjh6dzhfscl80i7ify8d-nload-0.7.4/bin
patching script interpreter paths in /nix/store/wj98jglp5z4pdjh6dzhfscl80i7ify8d-nload-0.7.4
checking for references to /build in /nix/store/wj98jglp5z4pdjh6dzhfscl80i7ify8d-nload-0.7.4...
/nix/store/wj98jglp5z4pdjh6dzhfscl80i7ify8d-nload-0.7.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nload

Partial log (click to expand)

make[1]: Leaving directory '/build/nload-0.7.4'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y6nppkpy1irwax7708i7wbkgv79f0lf9-nload-0.7.4
shrinking /nix/store/y6nppkpy1irwax7708i7wbkgv79f0lf9-nload-0.7.4/bin/nload
gzipping man pages under /nix/store/y6nppkpy1irwax7708i7wbkgv79f0lf9-nload-0.7.4/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y6nppkpy1irwax7708i7wbkgv79f0lf9-nload-0.7.4/bin
patching script interpreter paths in /nix/store/y6nppkpy1irwax7708i7wbkgv79f0lf9-nload-0.7.4
checking for references to /build in /nix/store/y6nppkpy1irwax7708i7wbkgv79f0lf9-nload-0.7.4...
/nix/store/y6nppkpy1irwax7708i7wbkgv79f0lf9-nload-0.7.4

@xeji
Copy link
Contributor

xeji commented Oct 11, 2018

The last tagged release is from 2012 but the upstream repo contains a number of bugfixes from 2018 (one of these is applied in this PR). We should consider upgrading the package to the latest git revision.

@xeji xeji merged commit 8362673 into NixOS:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @xeji @GrahamcOfBorg