Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simutrans: Fix hash of pak128 #48009

Closed
wants to merge 1 commit into from
Closed

simutrans: Fix hash of pak128 #48009

wants to merge 1 commit into from

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

It seems that 9b934a4 updated the expression for simutrans, but when nix-env -iA nixos.simutrans, it tells me:

fixed-output derivation produced path '/nix/store/b68pr406fns3b29zfnv6ihimmq6bgkmr-pak128.zip' with sha256 hash '0z01y7r0rz7q79vr17bbnkgcbjjrimphy1dwb1pgbiv4klz7j5xw' instead of the expected hash '1x6g6yfv1hvjyh3ciccly1i2k2n2b63dw694gdg4j90a543rmclg'

So I'm updating this hash here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b requested changes Oct 7, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The archive located at https://sourceforge.net/projects/simutrans/files/pak128/pak128%20for%20ST%20120.2.2%20%282.7%2C%20minor%20changes%29/pak128.zip/download actually has the SHA2-256 hash 1x6g6yfv1hvjyh3ciccly1i2k2n2b63dw694gdg4j90a543rmclg

It's srcPath which is incorrect: it's missing the .zip at the end

@matthiasbeyer
Copy link
Contributor Author

Outdated.

@matthiasbeyer matthiasbeyer deleted the fix-simutrans branch February 27, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @c0bw3b @GrahamcOfBorg