Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gramps: added support for recommended packages. #48008

Closed
wants to merge 1 commit into from

Conversation

joncojonathan
Copy link
Member

Motivation for this change

The GRAMPS readme indicates there are a number of recommended packages (graphviz, ghostscript,
PyICU and osm-gps-map which was already supported). These default to true.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

The GRAMPS readme indicates there are a number of recommended packages (graphviz, ghostscript,
PyICU and osm-gps-map which was already supported).  These default to true.
@timokau
Copy link
Member

timokau commented Oct 7, 2018

Closed in favor of #48010 which includes these changes.

@timokau timokau closed this Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants