Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.shell-conduit: fix build #48015

Merged
merged 1 commit into from Oct 14, 2018
Merged

haskellPackages.shell-conduit: fix build #48015

merged 1 commit into from Oct 14, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 7, 2018

Motivation for this change

These overrides are not needed anymore and actually makes the build fail on 18.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size
  • Fits CONTRIBUTING.md.

@ElvishJerricco
Copy link
Contributor

I was able to build this on both linux and darwin with three GHC releases, so it looks good to me.

$ nix build -f https://github.com/NixOS/nixpkgs/archive/096be6d9418e6ead24db1a56738d8a3086c298c5.tar.gz haskell.packages.{ghc843,ghc822,ghc802}.shell-conduit

@infinisil infinisil merged commit 1d51246 into NixOS:master Oct 14, 2018
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Oct 14, 2018 •
edited

Thank you!
@infinisil can you cherry pick this into 18.09?

@infinisil
Copy link
Member

@rnhmjoj Feel free to open a PR for that, will merge it when I see it

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Oct 14, 2018

Sure, right away.

@rnhmjoj rnhmjoj mentioned this pull request Oct 14, 2018
Merged
8 tasks
@rnhmjoj rnhmjoj deleted the shell-conduit branch February 23, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvishJerricco ElvishJerricco ElvishJerricco approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @ElvishJerricco @infinisil @GrahamcOfBorg