Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken packages from #47709 #47995

Merged
merged 2 commits into from Oct 10, 2018
Merged

fix broken packages from #47709 #47995

merged 2 commits into from Oct 10, 2018

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Oct 7, 2018 •
edited

Things done

I had a quick look at a Hydra evaluation of #47709 and fixed two packages that were broken by it:

  • vdirsyncer
  • ja2-stracciatella

This goes to staging, as IIRC the commits of #47709 are still there.

This should be backported to release-18.09, as the commits in question are already there.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@erictapen
Copy link
Member Author

vdirsyncer was fixed in de37b4c on nixos-18.09 by @gebner, so only ja2-stracciatella needs to be backported.

@gebner gebner changed the base branch from staging to master October 10, 2018 17:48
@gebner gebner changed the base branch from master to staging October 10, 2018 17:48
@gebner gebner merged commit c555a07 into NixOS:staging Oct 10, 2018
@erictapen
Copy link
Member Author

thanks for merging, backport is in d60bd3f.

@erictapen erictapen deleted the 47709-fallout branch October 11, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 8.has: clean-up 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @gebner @GrahamcOfBorg