Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndn-cxx: fixed broken build and updated to latest release #48706

Merged
merged 1 commit into from Oct 20, 2018
Merged

ndn-cxx: fixed broken build and updated to latest release #48706

merged 1 commit into from Oct 20, 2018

Conversation

sjmackenzie
Copy link
Contributor

Motivation for this change

ndn-cxx is broken and out of date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@sjmackenzie
Copy link
Contributor Author

@qknight mind taking a look at this mate?

@qknight qknight merged commit d0b9f95 into NixOS:master Oct 20, 2018
@sjmackenzie sjmackenzie deleted the ndn-fix branch November 7, 2018 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjmackenzie @qknight @GrahamcOfBorg