Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remmina: no webkit, optional gnome #48722

Merged
merged 3 commits into from Oct 19, 2018
Merged

remmina: no webkit, optional gnome #48722

merged 3 commits into from Oct 19, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Oct 19, 2018 •
edited by ryantm

Motivation for this change

See commit messages.

Things done
  • Worked before rebase.

/cc maintainers @melsigl @ryantm

@oxij
remmina: remove webkitgtk dependency
8ec6322 
It was used by "survey" module which was removed in revision
d97920eb9b32dbe17b85f8eff12928d26c19fd3d of their repository
on 2016-12-13.

Meanwhile, WebKit plugin is a separate package
https://aur.archlinux.org/packages/remmina-plugin-webkit/
not packaged in nixpkgs.
@oxij
remmina: make gnome support optional
972ec8b 
There's no runtime option to disable GNOME stuff, and storing things in
GNOME Keyring is very inconvenient for non-GNOME users.
@oxij
remmina: reindent
9f32d79
@ryantm ryantm self-requested a review October 19, 2018 19:32
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: remmina

Partial log (click to expand)

/nix/store/pnz6hd4a5bqwn6h58dnrphjaya63vkjj-remmina-1.2.32/share/remmina/external_tools/remmina_nslookup.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pnz6hd4a5bqwn6h58dnrphjaya63vkjj-remmina-1.2.32/share/remmina/external_tools/launcher.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pnz6hd4a5bqwn6h58dnrphjaya63vkjj-remmina-1.2.32/share/remmina/external_tools/remmina_filezilla_sftp_pki.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pnz6hd4a5bqwn6h58dnrphjaya63vkjj-remmina-1.2.32/bin/remmina-gnome: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/pnz6hd4a5bqwn6h58dnrphjaya63vkjj-remmina-1.2.32/bin/gnome-session-remmina: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/pnz6hd4a5bqwn6h58dnrphjaya63vkjj-remmina-1.2.32...
Wrapping program /nix/store/pnz6hd4a5bqwn6h58dnrphjaya63vkjj-remmina-1.2.32/bin/remmina-gnome
Wrapping program /nix/store/pnz6hd4a5bqwn6h58dnrphjaya63vkjj-remmina-1.2.32/bin/remmina
Wrapping program /nix/store/pnz6hd4a5bqwn6h58dnrphjaya63vkjj-remmina-1.2.32/bin/gnome-session-remmina
/nix/store/pnz6hd4a5bqwn6h58dnrphjaya63vkjj-remmina-1.2.32

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: remmina

Partial log (click to expand)

/nix/store/pqp1ysmhzva2ifry473ca3fc1i394kr0-remmina-1.2.32/share/remmina/external_tools/remmina_ping.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/pqp1ysmhzva2ifry473ca3fc1i394kr0-remmina-1.2.32/share/remmina/external_tools/remmina_nslookup.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/pqp1ysmhzva2ifry473ca3fc1i394kr0-remmina-1.2.32/share/remmina/external_tools/remmina_filezilla_sftp_pki.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/pqp1ysmhzva2ifry473ca3fc1i394kr0-remmina-1.2.32/share/remmina/external_tools/remmina_filezilla_sftp.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/pqp1ysmhzva2ifry473ca3fc1i394kr0-remmina-1.2.32/share/remmina/external_tools/functions.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/pqp1ysmhzva2ifry473ca3fc1i394kr0-remmina-1.2.32/share/remmina/external_tools/launcher.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/pqp1ysmhzva2ifry473ca3fc1i394kr0-remmina-1.2.32...
Wrapping program /nix/store/pqp1ysmhzva2ifry473ca3fc1i394kr0-remmina-1.2.32/bin/remmina-gnome
Wrapping program /nix/store/pqp1ysmhzva2ifry473ca3fc1i394kr0-remmina-1.2.32/bin/gnome-session-remmina
Wrapping program /nix/store/pqp1ysmhzva2ifry473ca3fc1i394kr0-remmina-1.2.32/bin/remmina

@Mic92 Mic92 merged commit 7f4608f into NixOS:master Oct 19, 2018
@jtojnar jtojnar mentioned this pull request Oct 27, 2018
Merged
9 tasks
@oxij oxij deleted the pkgs/remmina-no-webkit-no-gnome branch November 18, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oxij @GrahamcOfBorg @ryantm @jtojnar @Mic92