Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: servo/webrender
base: c72754d72ddd
Choose a base ref
...
head repository: servo/webrender
compare: 15656cb49730
Choose a head ref
  • 3 commits
  • 7 files changed
  • 2 contributors

Commits on Oct 18, 2018

  1. Store picture primitives in a vec, and refer by index in prims.

    This is prep work for changing the structure of the prepare_prims
    pass.
    
    Currently, the code is (roughly):
     - Traverse primitive tree, recursing through pictures.
      - When visible, call prepare_prim to update GPU cache, clips etc.
     - Assign render tasks to passes.
     - Assign primitive lists for each picture to batches.
    
    In future, it will instead be:
     - Traverse picture tree, but not individual primitives.
      - Determine surface allocation, plane-splitting, visibility.
     - For each visible picture, prepare_prims and add to batches.
    
    This will simplify some existing code, as well as making possible
    some requirements for picture caching (e.g. determining the scale
    to rasterize a picture at before creating the child render tasks).
    gw3583 committed Oct 18, 2018
    Copy the full SHA
    2193208 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. Remove PrimitiveMetadata struct.

    It doesn't really serve any useful purpose anymore, and it
    will slightly simplify things as we move to storing primitives
    as interned / immutable data + prim instances.
    gw3583 committed Oct 19, 2018
    Copy the full SHA
    b7ba28b View commit details
    Browse the repository at this point in the history
  2. Auto merge of #3218 - gw3583:prim-metadata, r=kvark

    Remove PrimitiveMetadata struct.
    
    It doesn't really serve any useful purpose anymore, and it
    will slightly simplify things as we move to storing primitives
    as interned / immutable data + prim instances.
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3218)
    <!-- Reviewable:end -->
    bors-servo committed Oct 19, 2018
    Copy the full SHA
    15656cb View commit details
    Browse the repository at this point in the history