Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anki: use send2trash from nixpkgs #48718

Merged
merged 2 commits into from Oct 19, 2018
Merged

Conversation

oxij
Copy link
Member

@oxij oxij commented Oct 19, 2018

Motivation for this change

Saves a bit of space.

Things done
  • Seems to work.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: anki

Partial log (click to expand)

tests/test_media.py .....                                                [ 52%]
tests/test_models.py ..........                                          [ 61%]
tests/test_sched.py ...............................                      [ 90%]
tests/test_stats.py ...                                                  [ 93%]
tests/test_undo.py ..                                                    [ 95%]
tests/test_upgrade.py .....                                              [100%]

========================= 107 passed in 19.27 seconds ==========================
pytestcachePhase
/nix/store/z541zjfx5v0505aswz6gan5n2rjs6prh-anki-2.0.52

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: anki

Partial log (click to expand)

vidix/pci_dev_ids.c:9:33: warning: 'dev_lst_001a' defined but not used [-Wunused-const-variable=]
 static const struct device_id_s dev_lst_001a[] = {
                                 ^~~~~~~~~~~~
vidix/pci_dev_ids.c:6:33: warning: 'dev_lst_0000' defined but not used [-Wunused-const-variable=]
 static const struct device_id_s dev_lst_0000[] = {
                                 ^~~~~~~~~~~~
builder for '/nix/store/0c2d13r5ahpn2hwpxp7ag4gk701q830l-mplayer-1.3.0.drv' failed with exit code 2
cannot build derivation '/nix/store/sal5vxfcxr4dm0mhvx9rp8mx6afaaqym-fix-paths.patch.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4a3kj7zn5y1j03i3kvk9zq5i5n6m754c-anki-2.0.52.drv': 2 dependencies couldn't be built
error: build of '/nix/store/4a3kj7zn5y1j03i3kvk9zq5i5n6m754c-anki-2.0.52.drv' failed

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 19, 2018

Could we use the opportunity to also update meta ? 😸

  • homepage is now https://apps.ankiweb.net/
  • license should be agpl3Plus according to LICENSE and source(s)
  • add broken = stdenv.hostPlatform.isAarch64; after platforms since it was never building according to Hydra

@oxij
Copy link
Member Author

oxij commented Oct 19, 2018 via email

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: anki

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: anki

Partial log (click to expand)

/nix/store/z541zjfx5v0505aswz6gan5n2rjs6prh-anki-2.0.52

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 19, 2018

Thanks!

@c0bw3b c0bw3b merged commit 42ead52 into NixOS:master Oct 19, 2018
@oxij oxij deleted the pkgs/anki-send-to-trash branch November 18, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants