Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip: 18.0 -> 18.1 #48702

Closed
wants to merge 1 commit into from
Closed

pip: 18.0 -> 18.1 #48702

wants to merge 1 commit into from

Conversation

leenaars
Copy link
Contributor

Motivation for this change

Version Bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@leenaars leenaars requested a review from FRidh as a code owner October 19, 2018 11:18
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 19, 2018

#47927 is already bumping pip

@c0bw3b c0bw3b closed this Oct 19, 2018
@leenaars
Copy link
Contributor Author

@c0bw3b: you are right, I'd missed that.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 19, 2018

No problem. :)
Since you have tested this, maybe you can help @FRidh with the review of #47927 (just leaving a comment saying what testing you did for example).

Thanks for your contribution nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leenaars @c0bw3b @GrahamcOfBorg