Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file: 5.34 -> 5.35 #48713

Merged
merged 1 commit into from Oct 20, 2018
Merged

file: 5.34 -> 5.35 #48713

merged 1 commit into from Oct 20, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Oct 19, 2018 •
edited 

* Add FreeBSD ELF core file support (John Baldwin)
* PR/30: Allow all parameter values to be set (don't treat 0 specially)
* handle default annotations on the softmagic match instead at the
  end.
* PR/23: Recognize JSON files
* PR/18: file --mime-encoding should not print mime-type
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: file

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hns07z2sisnxpnpqmi61br92ri128f12-file-5.35
shrinking /nix/store/hns07z2sisnxpnpqmi61br92ri128f12-file-5.35/bin/file
shrinking /nix/store/hns07z2sisnxpnpqmi61br92ri128f12-file-5.35/lib/libmagic.so.1.0.0
gzipping man pages under /nix/store/hns07z2sisnxpnpqmi61br92ri128f12-file-5.35/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hns07z2sisnxpnpqmi61br92ri128f12-file-5.35/lib  /nix/store/hns07z2sisnxpnpqmi61br92ri128f12-file-5.35/bin
patching script interpreter paths in /nix/store/hns07z2sisnxpnpqmi61br92ri128f12-file-5.35
checking for references to /build in /nix/store/hns07z2sisnxpnpqmi61br92ri128f12-file-5.35...
/nix/store/hns07z2sisnxpnpqmi61br92ri128f12-file-5.35

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: file

Partial log (click to expand)

make[1]: Leaving directory '/build/file-5.35'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jcxm7801gc5dr847zgs1j9bj4irn071r-file-5.35
shrinking /nix/store/jcxm7801gc5dr847zgs1j9bj4irn071r-file-5.35/bin/file
shrinking /nix/store/jcxm7801gc5dr847zgs1j9bj4irn071r-file-5.35/lib/libmagic.so.1.0.0
gzipping man pages under /nix/store/jcxm7801gc5dr847zgs1j9bj4irn071r-file-5.35/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jcxm7801gc5dr847zgs1j9bj4irn071r-file-5.35/lib  /nix/store/jcxm7801gc5dr847zgs1j9bj4irn071r-file-5.35/bin
patching script interpreter paths in /nix/store/jcxm7801gc5dr847zgs1j9bj4irn071r-file-5.35
checking for references to /build in /nix/store/jcxm7801gc5dr847zgs1j9bj4irn071r-file-5.35...

@FRidh FRidh merged commit eee82ae into NixOS:staging Oct 20, 2018
@dywedir dywedir deleted the file branch October 20, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @GrahamcOfBorg @FRidh