firefoxPackages.tor-browser: 7.5.6 -> 8.0.2 #48715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 19, 2018 16:46
Misc cleanups, but mainly this: Before: - `version` could mean either Firefox or TorBrowser version, - `configureFlags` was hacky. Now: - `ffversion` is Firefox version, `tbversion` is TorBrowser version, - `configureFlags` is much less hacky.
Mostly usable now.
|
Failure on x86_64-linux (full log) Attempted: firefoxPackages.tor-browser Partial log (click to expand)
|
|
Always something unexpected =/ |
|
Failure on aarch64-linux (full log) Attempted: firefoxPackages.tor-browser Partial log (click to expand)
|
|
@GrahamcOfBorg build firefoxPackages.firefox |
|
Failure on aarch64-linux (full log) Attempted: firefoxPackages.firefox Partial log (click to expand)
|
|
LGTM, though I have not tested it, cleanups seem sensible. It took me a few moments to see what happened to |
|
It took me a few moments to see what happened to `overrides` but I suppose that's an internal detail nobody is likely to depend on?
Yes. Standard `override` and `overrideAttrs` should be used instead.
OfBorg error for `tor-browser` seems really weird, though. It built flawlessly before rebase =/ I left it building on top of master to try to reproduce it, will see.
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: firefoxPackages.firefox Partial log (click to expand)
|
|
@GrahamcOfBorg build firefoxPackages.firefox |
|
Failure on aarch64-linux (full log) Attempted: firefoxPackages.firefox Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: firefoxPackages.firefox Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: firefoxPackages.firefox Partial log (click to expand)
|
oxij
force-pushed
the
pkgs/update-tor-browser
branch
2 times, most recently
from
b20c143
to
1ceb0ae
Compare
oxij
force-pushed
the
pkgs/update-tor-browser
branch
from
1ceb0ae
to
0e3df42
Compare
|
Ok, so SLNOS tor-browser fairy said that the OfBorg error above is https://bugzilla.mozilla.org/show_bug.cgi?id=1479540 which is firefox 60.2.1 incompatibility with rust fixed in 60.2.2.
I cherry-picked the fix into here, building now.
I checked that everything else in `firefoxPackages` still builds already.
|
|
Success on aarch64-linux (full log) Attempted: firefoxPackages.tor-browser Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: firefoxPackages.tor-browser Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: firefoxPackages.tor-browser, firefoxPackages.tor-browser-8-0 Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: firefoxPackages.tor-browser, firefoxPackages.tor-browser-8-0 Partial log (click to expand)
|
|
I take it this is good to go now? |
|
Yes. Everything builds now.
|
|
Awesome. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update.
Things done
firefoxPackagesand they still build fine.firefoxand bothtor-browser*outputs still work as before.tor-browser-bundleis likely to need changes after this./cc @joachifm