Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: 1.8.2 -> 3.0.5 #48711

Merged
merged 1 commit into from Oct 20, 2018
Merged

electron: 1.8.2 -> 3.0.5 #48711

merged 1 commit into from Oct 20, 2018

Conversation

c0deaddict
Copy link
Member

@c0deaddict c0deaddict commented Oct 19, 2018

Motivation for this change

The current version in nixpkgs is old. Only tested the build on x86_64-linux.

hyper-haskell depends on electron and fails to build. But that is not related to the version bump of electron, it also fails to build with 1.8.2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants