Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: servo/webrender
base: f4941fb8d126
Choose a base ref
...
head repository: servo/webrender
compare: c72754d72ddd
Choose a head ref
  • 3 commits
  • 3 files changed
  • 3 contributors

Commits on Oct 19, 2018

  1. Skip clip masks with tiled blobs, instead of crashing. 

    We don't currently support tiled blobs for clip masks (see
issue #2852). This patch detects that case, and skips applying
a clip mask in that case. It's not ideal, but it's better
than crashing inside the resource cache, which is the current
behavior.
    @gw3583
    gw3583 committed Oct 19, 2018
    Copy the full SHA
    4dc6618 View commit details
    Browse the repository at this point in the history

  2. Add a comment for the boolean member in ClipItem::ImageMask.

    @emilio
    emilio committed Oct 19, 2018
    Copy the full SHA
    207cfec View commit details
    Browse the repository at this point in the history

  3. Auto merge of #3219 - gw3583:clip-tile-workaround, r=nical 

    Skip clip masks with tiled blobs, instead of crashing.

We don't currently support tiled blobs for clip masks (see
issue #2852). This patch detects that case, and skips applying
a clip mask in that case. It's not ideal, but it's better
than crashing inside the resource cache, which is the current
behavior.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3219)
<!-- Reviewable:end -->
    bors-servo committed Oct 19, 2018
    Copy the full SHA
    c72754d View commit details
    Browse the repository at this point in the history