Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 18.09] nextcloud module: init #47859

Merged
merged 5 commits into from Oct 21, 2018
Merged

[Backport 18.09] nextcloud module: init #47859

merged 5 commits into from Oct 21, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 4, 2018

Motivation for this change

This backports #47159 to 18.09. Filed a separate PR to run tests as suggested by @Mic92 in #47159 (comment) .

I decided to keep the bump to 14.0.1 around, due to that release supporting 2FA and having a "Data Protection Confirmation app and separate audit log file" application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @eqyiel @fpletz @globin @Ekleog

fpletz and others added 3 commits October 4, 2018 10:41
@fpletz @globin
@dasJ @flokli
nixos/nextcloud: init
55c24a0 
(cherry picked from commit ebd3818)

Co-authored-by: Franz Pletz <fpletz@fnordicwalking.de>
Co-authored-by: Robin Gloster <mail@glob.in>
Co-authored-by: Janne Heß <janne@hess.ooo>
Co-authored-by: Florian Klink <flokli@flokli.de>
@eqyiel @globin @flokli
nextcloud: 13.0.6 -> 14.0.1
ac5fc67 
(cherry picked from commit e5b3ea5)

Co-authored-by: Robin Gloster <mail@glob.in>
@flokli
nextcloud: fix sendmail path discovery
cc34043 
(cherry picked from commit 1fd6477)
@flokli flokli changed the title [Backport] nextcloud module: init [Backport 18.09] nextcloud module: init Oct 4, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nextcloud

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/li1gmn62kfarmbmch9vx5q248kgh4lzh-nextcloud-14.0.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/li1gmn62kfarmbmch9vx5q248kgh4lzh-nextcloud-14.0.1/lib
patching script interpreter paths in /nix/store/li1gmn62kfarmbmch9vx5q248kgh4lzh-nextcloud-14.0.1
checking for references to /build in /nix/store/li1gmn62kfarmbmch9vx5q248kgh4lzh-nextcloud-14.0.1...
/nix/store/li1gmn62kfarmbmch9vx5q248kgh4lzh-nextcloud-14.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nextcloud

Partial log (click to expand)

configuring
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2p3ffl8iz7hrrnr9si0id2c07i6yr93z-nextcloud-14.0.1/lib
patching script interpreter paths in /nix/store/2p3ffl8iz7hrrnr9si0id2c07i6yr93z-nextcloud-14.0.1
/nix/store/2p3ffl8iz7hrrnr9si0id2c07i6yr93z-nextcloud-14.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nextcloud

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ar3fnalsd3dy3cn4ikjf7z52q7mrrlyx-nextcloud-14.0.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ar3fnalsd3dy3cn4ikjf7z52q7mrrlyx-nextcloud-14.0.1/lib
patching script interpreter paths in /nix/store/ar3fnalsd3dy3cn4ikjf7z52q7mrrlyx-nextcloud-14.0.1
checking for references to /build in /nix/store/ar3fnalsd3dy3cn4ikjf7z52q7mrrlyx-nextcloud-14.0.1...
/nix/store/ar3fnalsd3dy3cn4ikjf7z52q7mrrlyx-nextcloud-14.0.1

@Mic92
Copy link
Member

Mic92 commented Oct 4, 2018

cc @schneefux @bachp

@Mic92
Copy link
Member

Mic92 commented Oct 4, 2018

@GrahamcOfBorg test nextcloud.basic nextcloud.with-mysql-and-memcached nextcloud.with-postgresql-and-redis

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.nextcloud.basic, tests.nextcloud.with-mysql-and-memcached, tests.nextcloud.with-postgresql-and-redis

Partial log (click to expand)

nextcloud: exit status 0
test script finished in 17.68s
cleaning up
killing client (pid 600)
killing nextcloud (pid 612)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/i5vcw9fw54fzqkvy0j033838vfh6h8g3-vm-test-run-nextcloud-basic
/nix/store/75nb9wvkv1dqv9v87z23131m9rfk8rcq-vm-test-run-nextcloud-with-mysql-and-memcached
/nix/store/2vc4wfj1p6dik8cp5zq08ihxamln89p6-vm-test-run-nextcloud-with-postgresql-and-redis

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.nextcloud.basic, tests.nextcloud.with-mysql-and-memcached, tests.nextcloud.with-postgresql-and-redis

Partial log (click to expand)

nextcloud: exit status 0
test script finished in 201.12s
cleaning up
killing client (pid 631)
killing nextcloud (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/6q12byimpylcak97r27hf5090swwsnnj-vm-test-run-nextcloud-basic
/nix/store/0bjap8yacsmhhf9j9m79yiks3g6y51i3-vm-test-run-nextcloud-with-mysql-and-memcached
/nix/store/xxzicfxywha9fyzgyg64xv9mxhmd9plj-vm-test-run-nextcloud-with-postgresql-and-redis

@samueldr
Copy link
Member

samueldr commented Oct 6, 2018 •
edited

Haven't looked at the PR in details yet.

Nextcloud probably goes into the security sensitive category for backports; it's often exposed to the whole wild web. Unless it gets an LTS version, or another distro has security patches handy, it will probably always need to be updated in the stable release, so it's easier to apply security updates as needed.

The fact that it adds a test for nextcloud makes me less hesitant to include this change into an already released stable branch, though this is still way past the branch freese :/.

@flokli
Copy link
Contributor Author

flokli commented Oct 6, 2018

@samueldr according to https://nextcloud.com/release-channels/, nextcloud does have a concept of release channels, although they don't explicitly show on the website which version is currently on which channel.

According to the URL above, the latest stable version can be found on the installation page, which is currently pointing to 14.0.1, so we should be good.

@flokli
Copy link
Contributor Author

flokli commented Oct 8, 2018

I did dig a bit deeper into it. Nextclouds updater logic polls some updater server, it's configuration can be found here:
https://github.com/nextcloud/updater_server/blob/master/config/config.php#L106

So basically nextcloud 14.0.1 is also delivered on both "production" and "stable" channels.

@Ekleog
Copy link
Member

Ekleog commented Oct 20, 2018 via email

Vskilet and others added 2 commits October 21, 2018 15:06
@globin
Copy link
Member

globin commented Oct 21, 2018

@GrahamcOfBorg test nextcloud.basic nextcloud.with-mysql-and-memcached nextcloud.with-postgresql-and-redis

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.nextcloud.basic, tests.nextcloud.with-mysql-and-memcached, tests.nextcloud.with-postgresql-and-redis

Partial log (click to expand)

client: exit status 0
test script finished in 280.44s
cleaning up
killing nextcloud (pid 631)
killing client (pid 644)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/ccwwi3l27vq6q21wdffjc4fifc12ip07-vm-test-run-nextcloud-basic
/nix/store/sbhag7cybdhni25w5z2qb3zfgyyxpbra-vm-test-run-nextcloud-with-mysql-and-memcached
/nix/store/9k92c96xkcm7d264gz5f6z8949glcjjs-vm-test-run-nextcloud-with-postgresql-and-redis

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.nextcloud.basic, tests.nextcloud.with-mysql-and-memcached, tests.nextcloud.with-postgresql-and-redis

Partial log (click to expand)

nextcloud: exit status 0
test script finished in 246.00s
cleaning up
killing client (pid 597)
killing nextcloud (pid 609)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/x0by2kpks4yb7qgmsxh40sm30nkrgdfs-vm-test-run-nextcloud-basic
/nix/store/lldw27bsdj7hjsr1xs7fa9andh363wh3-vm-test-run-nextcloud-with-mysql-and-memcached
/nix/store/ywkf1cnrp06b7hq2fqdwgavh6579amzj-vm-test-run-nextcloud-with-postgresql-and-redis

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nextcloud

Partial log (click to expand)

/nix/store/kihscva3p0vvy7kilmxnjncxifjy80dq-nextcloud-14.0.3

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: nextcloud

Partial log (click to expand)

copying path '/nix/store/qfag24z6xsr6jkyi8gb4cv62rp945rbk-gnumake-4.2.1' from 'https://cache.nixos.org'...
copying path '/nix/store/95bw3cdcgc8c0rrvqwvhvc805pdv7rmx-stdenv-darwin' from 'https://cache.nixos.org'...
building '/nix/store/h9vvmpb7jg4ivacfv5dj45ss68zsj5yv-nextcloud-14.0.3.drv'...
/nix/store/nsi1xkmlk3dd51ln3jyv2dmgzpj9miwx-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/nsi1xkmlk3dd51ln3jyv2dmgzpj9miwx-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/nsi1xkmlk3dd51ln3jyv2dmgzpj9miwx-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/nsi1xkmlk3dd51ln3jyv2dmgzpj9miwx-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/nsi1xkmlk3dd51ln3jyv2dmgzpj9miwx-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: Resource temporarily unavailable
builder for '/nix/store/h9vvmpb7jg4ivacfv5dj45ss68zsj5yv-nextcloud-14.0.3.drv' failed with exit code 254
error: build of '/nix/store/h9vvmpb7jg4ivacfv5dj45ss68zsj5yv-nextcloud-14.0.3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nextcloud

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/x9i6jp7d0lmydnxhv3csbklrx93y3pci-nextcloud-14.0.3
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x9i6jp7d0lmydnxhv3csbklrx93y3pci-nextcloud-14.0.3/lib
patching script interpreter paths in /nix/store/x9i6jp7d0lmydnxhv3csbklrx93y3pci-nextcloud-14.0.3
checking for references to /build in /nix/store/x9i6jp7d0lmydnxhv3csbklrx93y3pci-nextcloud-14.0.3...
/nix/store/x9i6jp7d0lmydnxhv3csbklrx93y3pci-nextcloud-14.0.3

@globin globin merged commit 08a0f3f into NixOS:release-18.09 Oct 21, 2018
@flokli flokli deleted the nextcloud-module-18.09 branch October 21, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@flokli @GrahamcOfBorg @Mic92 @samueldr @Ekleog @globin @fpletz @eqyiel @Vskilet