Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yapf: 0.22.0 -> 0.24.0 #47858

Merged
merged 1 commit into from Oct 4, 2018
Merged

yapf: 0.22.0 -> 0.24.0 #47858

merged 1 commit into from Oct 4, 2018

Conversation

pmiddend
Copy link
Contributor

@pmiddend pmiddend commented Oct 4, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@pmiddend pmiddend requested a review from FRidh as a code owner October 4, 2018 08:38
@bhipple
Copy link
Contributor

bhipple commented Oct 4, 2018

@GrahamcOfBorg build pythonPackages.yapf

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.yapf

Partial log (click to expand)

checking for references to /build in /nix/store/wr897258krnhj4w0clzpc49mhi79a7r6-python2.7-yapf-0.24.0...
wrapping `/nix/store/wr897258krnhj4w0clzpc49mhi79a7r6-python2.7-yapf-0.24.0/bin/yapf'...
running install tests
running test
................................................s...............s...................................................................................................................................................................................................................................................................................................................................................................................................sssssssssssssssssss.................................
----------------------------------------------------------------------
Ran 504 tests in 22.115s

OK (skipped=21)
/nix/store/wr897258krnhj4w0clzpc49mhi79a7r6-python2.7-yapf-0.24.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.yapf

Partial log (click to expand)

checking for references to /build in /nix/store/8lp025491gh4gfwdj1ia8d401wsjgab4-python2.7-yapf-0.24.0...
wrapping `/nix/store/8lp025491gh4gfwdj1ia8d401wsjgab4-python2.7-yapf-0.24.0/bin/yapf'...
running install tests
running test
................................................s...............s...................................................................................................................................................................................................................................................................................................................................................................................................sssssssssssssssssss.................................
----------------------------------------------------------------------
Ran 504 tests in 10.756s

OK (skipped=21)
/nix/store/8lp025491gh4gfwdj1ia8d401wsjgab4-python2.7-yapf-0.24.0

@Mic92
Copy link
Member

Mic92 commented Oct 4, 2018 •
edited

@pmiddend can you ask for ofborg access? NixOS/ofborg#239

@Mic92
Copy link
Member

Mic92 commented Oct 4, 2018

Did it catch up with https://github.com/ambv/black already?

@Mic92 Mic92 merged commit c7b7eb3 into NixOS:master Oct 4, 2018
@pmiddend pmiddend deleted the yapf_0_24_0 branch October 5, 2018 07:34
@pmiddend pmiddend mentioned this pull request Oct 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmiddend @bhipple @GrahamcOfBorg @Mic92