Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taskell: init at 1.3.2 #47866

Merged
merged 1 commit into from Oct 13, 2018
Merged

taskell: init at 1.3.2 #47866

merged 1 commit into from Oct 13, 2018

Conversation

matthiasbeyer
Copy link
Contributor

@Profpatsch please ACK this, as you're in the git trailers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@matthiasbeyer
taskell: init at 1.3.2
508d2db 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Suggested-by: Profpatsch <mail@profpatsch.de>
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: taskell

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: taskell

Partial log (click to expand)

shrinking /nix/store/lvg1czavyyl8s7z93wdgzx1gkhybg3c5-taskell-1.3.2/bin/taskell
shrinking /nix/store/lvg1czavyyl8s7z93wdgzx1gkhybg3c5-taskell-1.3.2/lib/ghc-8.4.3/x86_64-linux-ghc-8.4.3/taskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y/HStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y.o
wrong ELF type
shrinking /nix/store/lvg1czavyyl8s7z93wdgzx1gkhybg3c5-taskell-1.3.2/lib/ghc-8.4.3/x86_64-linux-ghc-8.4.3/libHStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y-ghc8.4.3.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lvg1czavyyl8s7z93wdgzx1gkhybg3c5-taskell-1.3.2/lib  /nix/store/lvg1czavyyl8s7z93wdgzx1gkhybg3c5-taskell-1.3.2/bin
patching script interpreter paths in /nix/store/lvg1czavyyl8s7z93wdgzx1gkhybg3c5-taskell-1.3.2
checking for references to /build in /nix/store/lvg1czavyyl8s7z93wdgzx1gkhybg3c5-taskell-1.3.2...
wrong ELF type
/nix/store/lvg1czavyyl8s7z93wdgzx1gkhybg3c5-taskell-1.3.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: taskell

Partial log (click to expand)

/nix/store/d8xjzrlnd6z4a6nc8i1k6h50crx9w1pz-taskell-1.3.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y-ghc8.4.3.dylib: fixing dylib
/nix/store/d8xjzrlnd6z4a6nc8i1k6h50crx9w1pz-taskell-1.3.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y-ghc8.4.3.dylib: fixing dylib
/nix/store/d8xjzrlnd6z4a6nc8i1k6h50crx9w1pz-taskell-1.3.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y-ghc8.4.3.dylib: fixing dylib
/nix/store/d8xjzrlnd6z4a6nc8i1k6h50crx9w1pz-taskell-1.3.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y-ghc8.4.3.dylib: fixing dylib
/nix/store/d8xjzrlnd6z4a6nc8i1k6h50crx9w1pz-taskell-1.3.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y-ghc8.4.3.dylib: fixing dylib
/nix/store/d8xjzrlnd6z4a6nc8i1k6h50crx9w1pz-taskell-1.3.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y-ghc8.4.3.dylib: fixing dylib
/nix/store/d8xjzrlnd6z4a6nc8i1k6h50crx9w1pz-taskell-1.3.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y-ghc8.4.3.dylib: fixing dylib
/nix/store/d8xjzrlnd6z4a6nc8i1k6h50crx9w1pz-taskell-1.3.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y-ghc8.4.3.dylib: fixing dylib
/nix/store/d8xjzrlnd6z4a6nc8i1k6h50crx9w1pz-taskell-1.3.2/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHStaskell-1.3.2.0-DNYXVOnbWbz6VjqBBCBa3Y-ghc8.4.3.dylib: fixing dylib
/nix/store/d8xjzrlnd6z4a6nc8i1k6h50crx9w1pz-taskell-1.3.2

Profpatsch
Profpatsch reviewed Oct 4, 2018
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay from my side, I wrote the code after all. :)

pkgs/applications/misc/taskell/default.nix

postPatch = ''${haskellPackages.hpack}/bin/hpack'';

# basically justStaticExecutables; TODO: use justStaticExecutables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno what we should do about this. I tried for about 5 minutes to get it to run with haskellPackages.callPackage, but just copying the arguments was easier. Would be nicer if we could use justStaticExecutables.

@matthiasbeyer
Copy link
Contributor Author

Status?

@Profpatsch
Copy link
Member

lgtm

@Profpatsch Profpatsch merged commit b73579e into NixOS:master Oct 13, 2018
@matthiasbeyer matthiasbeyer deleted the add-taskell branch October 13, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @GrahamcOfBorg @Profpatsch