Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: add plugins tests #47861

Merged
merged 2 commits into from Oct 4, 2018
Merged

terraform: add plugins tests #47861

merged 2 commits into from Oct 4, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Oct 4, 2018

I wasn't sure if the plugins were downloaded from the Internet or not.
This makes sure that there is no regression in the plugin detection.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm
terraform: add plugins tests
953e1f5 
I wasn't sure if the plugins were downloaded from the Internet or not.
This makes sure that there is no regression in the plugin detection.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: terraform

Partial log (click to expand)

these paths will be fetched (13.15 MiB download, 98.14 MiB unpacked):
  /nix/store/53zq7kk9k5q6z54lbm2hr3cb2mb5z463-terraform-0.11.8-bin
copying path '/nix/store/53zq7kk9k5q6z54lbm2hr3cb2mb5z463-terraform-0.11.8-bin' from 'https://cache.nixos.org'...
/nix/store/53zq7kk9k5q6z54lbm2hr3cb2mb5z463-terraform-0.11.8-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: terraform

Partial log (click to expand)

these paths will be fetched (25.99 MiB download, 113.70 MiB unpacked):
  /nix/store/qgcb0nfpaxbd36qd24izwgyghg3jhb9k-terraform-0.11.8-bin
copying path '/nix/store/qgcb0nfpaxbd36qd24izwgyghg3jhb9k-terraform-0.11.8-bin' from 'https://cache.nixos.org'...
/nix/store/qgcb0nfpaxbd36qd24izwgyghg3jhb9k-terraform-0.11.8-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: terraform

Partial log (click to expand)

these paths will be fetched (14.41 MiB download, 102.57 MiB unpacked):
  /nix/store/hkw730y8mvzw3672wgdy1nam971k6xmx-terraform-0.11.8-bin
copying path '/nix/store/hkw730y8mvzw3672wgdy1nam971k6xmx-terraform-0.11.8-bin' from 'https://cache.nixos.org'...
/nix/store/hkw730y8mvzw3672wgdy1nam971k6xmx-terraform-0.11.8-bin

Mic92
Mic92 reviewed Oct 4, 2018
View reviewed changes
pkgs/applications/networking/cluster/terraform/default.nix
# Tests that the plugins are being used. Terraform looks at the specific
# file pattern and if the plugin is not found it will try to download it
# from the Internet. With sandboxing enable this test will fail if that is
# the case.
Copy link
Member

@Mic92 Mic92 Oct 4, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

export HTTP_PROXY=http://127.0.0.1:0 HTTPS_PROXY=https://127.0.0.1:0

might also make it work without relying on the sandbox.
But maybe the current solution is already good enough.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, added

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: terraform

Partial log (click to expand)

/nix/store/53zq7kk9k5q6z54lbm2hr3cb2mb5z463-terraform-0.11.8-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: terraform

Partial log (click to expand)

/nix/store/hkw730y8mvzw3672wgdy1nam971k6xmx-terraform-0.11.8-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: terraform

Partial log (click to expand)

these paths will be fetched (25.99 MiB download, 113.70 MiB unpacked):
  /nix/store/qgcb0nfpaxbd36qd24izwgyghg3jhb9k-terraform-0.11.8-bin
copying path '/nix/store/qgcb0nfpaxbd36qd24izwgyghg3jhb9k-terraform-0.11.8-bin' from 'https://cache.nixos.org'...
/nix/store/qgcb0nfpaxbd36qd24izwgyghg3jhb9k-terraform-0.11.8-bin

@zimbatm zimbatm merged commit d4ff6ca into NixOS:master Oct 4, 2018
@zimbatm zimbatm deleted the terraform-plugin-test branch October 4, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @GrahamcOfBorg @Mic92