Purge more bloat from registry.json
#2564
Merged
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
|
We can save another 5MB if we remove the indentation of the json. Downside is that it will be very hard to read as everything is set on 1 line. Code that indents the json: CKAN/Core/Registry/RegistryManager.cs Lines 361 to 363 in caeb50d |
|
Hmm, it's not too bad if we keep the line breaks:
|
HebaruSan
changed the title
registry.jsonregistry.json
|
Doesn't look bad. We can always remove the identation completely if the file grows too big again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
registry.jsonfile nowadays is about 20 MB, 10% of which is repetitions of the following lines:"ksp_version_strict": false,"download_content_type": "application/zip","find_matches_files": false,"install_to": "GameData"(without a comma)"install_to": "GameData",(with a comma)A further 3.5 MB is tab characters indenting the JSON. While it can be useful to inspect this file from time to time, its primary function is to be read by code, so this formatting is not necessary.
This takes up disk space and increases the time to save and load the registry.
Changes
Now the above values of the above properties are treated as the default; when the property has that value, it will be left out of the serialization, and if the property is missing when de-serializing, it will be set to the default. There will be no change in runtime behavior because the de-serializer will still set the properties as needed.
Similarly, the indenting is removed (but the line breaks remain).
This reduces the size of
registry.jsonby about 5.5 MB, similar to #2179.