Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor: 0.3.4.8 -> 0.3.4.9 #49652

Merged
merged 1 commit into from Nov 3, 2018
Merged

tor: 0.3.4.8 -> 0.3.4.9 #49652

merged 1 commit into from Nov 3, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 2, 2018

https://gitweb.torproject.org/tor.git/plain/ChangeLog?h=tor-0.3.4.9

Please confirm the sha256 is correct for a verified tarball,
I'm not setup (or know how offhand but docs look promising)
to do this myself.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
tor: 0.3.4.8 -> 0.3.4.9
c78761b 
https://gitweb.torproject.org/tor.git/plain/ChangeLog?h=tor-0.3.4.9

Please confirm the sha256 is correct for a verified tarball,
I'm not setup (or know how offhand but docs look promising)
to do this myself.
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: tor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@dtzWill dtzWill requested a review from joachifm November 2, 2018 18:42
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tor

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vgpwkhx75iil2ajiky8wl1wr116lq9b1-tor-0.3.4.9/bin
patching script interpreter paths in /nix/store/vgpwkhx75iil2ajiky8wl1wr116lq9b1-tor-0.3.4.9
/nix/store/vgpwkhx75iil2ajiky8wl1wr116lq9b1-tor-0.3.4.9/bin/torify: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/vgpwkhx75iil2ajiky8wl1wr116lq9b1-tor-0.3.4.9...
shrinking RPATHs of ELF executables and libraries in /nix/store/y7bha3l6j5v696m7n6zwin9gz7ibjl3l-tor-0.3.4.9-geoip
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/y7bha3l6j5v696m7n6zwin9gz7ibjl3l-tor-0.3.4.9-geoip
checking for references to /build in /nix/store/y7bha3l6j5v696m7n6zwin9gz7ibjl3l-tor-0.3.4.9-geoip...
/nix/store/vgpwkhx75iil2ajiky8wl1wr116lq9b1-tor-0.3.4.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tor

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d8z0r61hin2c50nfxa0djgc5yrxhsnxm-tor-0.3.4.9/bin
patching script interpreter paths in /nix/store/d8z0r61hin2c50nfxa0djgc5yrxhsnxm-tor-0.3.4.9
/nix/store/d8z0r61hin2c50nfxa0djgc5yrxhsnxm-tor-0.3.4.9/bin/torify: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/d8z0r61hin2c50nfxa0djgc5yrxhsnxm-tor-0.3.4.9...
shrinking RPATHs of ELF executables and libraries in /nix/store/1f2pr6c6pjqq1mpanaxw1yi5yhj54fcn-tor-0.3.4.9-geoip
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/1f2pr6c6pjqq1mpanaxw1yi5yhj54fcn-tor-0.3.4.9-geoip
checking for references to /build in /nix/store/1f2pr6c6pjqq1mpanaxw1yi5yhj54fcn-tor-0.3.4.9-geoip...
/nix/store/d8z0r61hin2c50nfxa0djgc5yrxhsnxm-tor-0.3.4.9

@joachifm
Copy link
Contributor

joachifm commented Nov 3, 2018

LGTM. Note that the update script will take care of verifying the tarball, as in

nix-shell maintainers/scripts/update.nix --argstr package tor

@joachifm joachifm merged commit 0e76e13 into NixOS:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @joachifm